Metal: Optimise shader texture cache usage and branch reduction via point sampling.
ClosedPublic
Actions

Authored by Jason Fielder (jason_apple) on Tue, Jan 17, 5:56 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T96261: Metal Viewport

Commits

rBf3bd5458a39b: Metal: Optimise shader texture cache usage and branch reduction via point…

Summary

Replace texelFetch calls with a texture point-sample rather than a textureRead call. This increases texture cache utilisation when mixing between sampled calls and reads. Bounds checking can also be removed from these functions, reducing instruction count and branch divergence, as the sampler routine handles range clamping.

Authored by Apple: Michael Parkin-White
Ref T96261

Depends on D16923

Diff Detail

Repository: rB Blender

Event Timeline

Jason Fielder (jason_apple) requested review of this revision.Tue, Jan 17, 5:56 PM

Jason Fielder (jason_apple) created this revision.

Harbormaster completed remote builds in B25408: Diff 59532.Tue, Jan 17, 5:56 PM

Clément Foucault (fclem) accepted this revision.Mon, Jan 23, 10:49 AM

This revision is now accepted and ready to land.Mon, Jan 23, 10:49 AM

NOTE: Overlaps with (https://developer.blender.org/D16923) - fixing EEVEE shader compilations, with changes to 1D texture sampling. Best to first land the other patch. I will re-base this afterwards.

Michael Parkin-White (MichaelPW) edited the summary of this revision. (Show Details)Mon, Jan 23, 12:26 PM

Michael Parkin-White (MichaelPW) added a parent revision: D16923: Fix T103635: Fix failing EEVEE and OCIO shader compilations in Metal..

Feedback addressed

Harbormaster completed remote builds in B25603: Diff 60063.Mon, Jan 30, 5:55 PM

Rebased against latest master.

Closed by commit rBf3bd5458a39b: Metal: Optimise shader texture cache usage and branch reduction via point… (authored by Jason Fielder (jason_apple), committed by Clément Foucault (fclem)). · Explain WhyTue, Jan 31, 11:04 AM

This revision was automatically updated to reflect the committed changes.

Clément Foucault (fclem) added a commit: rBf3bd5458a39b: Metal: Optimise shader texture cache usage and branch reduction via point….