Refactor: replace `bool beckmann` with `enum MicrofacetType` for readability
ClosedPublic
Actions

Authored by Weizhen Huang (weizhen) on Thu, Jan 19, 12:54 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Commits

rB9b7c2cca3df8: Refactor: replace `bool beckmann` with `enum MicrofacetType` for readability

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 25450
Build 25450: arc lint + arc unit

Event Timeline

Weizhen Huang (weizhen) requested review of this revision.Thu, Jan 19, 12:54 PM

Weizhen Huang (weizhen) created this revision.

Harbormaster completed remote builds in B25450: Diff 59622.Thu, Jan 19, 12:54 PM

G = bsdf_G<MicrofacetType::BECKMANN>(alpha2, cosNI, cosNO); is so much more readable!

This revision is now accepted and ready to land.Thu, Jan 19, 3:35 PM

Sergey Sharybin (sergey) awarded a token.Thu, Jan 19, 3:35 PM

Closed by commit rB9b7c2cca3df8: Refactor: replace `bool beckmann` with `enum MicrofacetType` for readability (authored by Weizhen Huang (weizhen)). · Explain WhyThu, Jan 19, 4:31 PM

This revision was automatically updated to reflect the committed changes.

Weizhen Huang (weizhen) added a commit: rB9b7c2cca3df8: Refactor: replace `bool beckmann` with `enum MicrofacetType` for readability.

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

closure/

bsdf_microfacet.h

91 lines

integrator/

mnee.h

4 lines

Diff 59622

View Options

intern/cycles/kernel/closure/bsdf_microfacet.h