Paths

Table of Contentst

Differential D17047

Curves: Edit mode selection operators
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Thu, Jan 19, 5:51 PM.

Tags

Subscribers

Hans Goudey (HooglyBoogly)

Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rB70ca15670d9f: Curves: Edit mode selection operators

Summary

This is based on D16835 with a few improvements:

The core part of the selection functions are separated out into curves_selection.cc. This is done so that other objects that use CurvesGeometry can also make use of the selection code.
The selection functions either use an existing .selection attribute, or creates a new boolean .selection attribute.

Note:

For now, the select_grow operator is not supported in edit mode.
Patch should be tested with D16979 applied

Diff Detail

Repository

Branch

arcpatch-D16835 (branched from master)

Build Status

Buildable 25458
Build 25458: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Thu, Jan 19, 5:51 PM

Falk David (filedescriptor) created this revision.

Harbormaster completed remote builds in B25458: Diff 59649.Thu, Jan 19, 5:51 PM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Thu, Jan 19, 5:53 PM

Remove select_grow shortcut in edit mode

Harbormaster completed remote builds in B25459: Diff 59651.Thu, Jan 19, 5:58 PM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Thu, Jan 19, 5:59 PM

Hans Goudey (HooglyBoogly) accepted this revision.Thu, Jan 19, 6:13 PM

Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/editors/curves/intern/curves_ops.cc
10–12	Not sure all these new includes are needed
1072	Guessing this is copied from somewhere, but comment formatting still :)
source/blender/editors/sculpt_paint/curves_sculpt_ops.cc
800	Not sure I agree with this rename, the operator is part of the "sculpt curves" area, like others, make sense to keep that name prefix IMO. Same with select_random

This revision is now accepted and ready to land.Thu, Jan 19, 6:13 PM

Falk David (filedescriptor) added inline comments.Thu, Jan 19, 6:18 PM

source/blender/editors/sculpt_paint/curves_sculpt_ops.cc
800	Ah yes, I wanted to ask you about this. The issue is that in python this would also appear as `curves.select_random`/`curves.select_grow`. So I added the `sculpt` part in the name of the actual operator. I'm open to another, better, solution of course!

Hans Goudey (HooglyBoogly) added inline comments.Thu, Jan 19, 6:22 PM

source/blender/editors/sculpt_paint/curves_sculpt_ops.cc
800	Hmm, why is that? In current master I see this: >>> bpy.ops.sculpt_curves. brush_stroke( min_distance_edit( select_end( select_grow( select_random( >>> bpy.ops.curves <module 'bpy.ops.curves'>

Falk David (filedescriptor) added inline comments.Thu, Jan 19, 6:29 PM

source/blender/editors/sculpt_paint/curves_sculpt_ops.cc
800	You're absolutely right, my bad. Reverting...

Revert name changes to sculpt selection operators

Harbormaster completed remote builds in B25464: Diff 59656.Thu, Jan 19, 6:31 PM

Falk David (filedescriptor) added a project: Nodes & Physics.Thu, Jan 19, 6:50 PM

Hans Goudey (HooglyBoogly) accepted this revision.Thu, Jan 19, 6:52 PM

Hans Goudey (HooglyBoogly) added inline comments.

release/scripts/modules/rna_manual_reference.py
1585	The grow name should remain unchanged too, right? Anyway, this file is autogenerated and shouldn't be adjusted here

Merge branch 'master'

Harbormaster completed remote builds in B25467: Diff 59660.Thu, Jan 19, 6:53 PM

Revert changes to rna_manual_reference.py

Harbormaster completed remote builds in B25468: Diff 59661.Thu, Jan 19, 6:55 PM

Fix python menu and shortcut

Harbormaster completed remote builds in B25469: Diff 59663.Thu, Jan 19, 6:57 PM

Hans Goudey (HooglyBoogly) accepted this revision.Thu, Jan 19, 6:59 PM

Falk David (filedescriptor) edited the summary of this revision. (Show Details)Thu, Jan 19, 7:03 PM

Philipp Oeser (lichtwerk) mentioned this in D16835: Curves editmode: add existing selection operators and domain.Fri, Jan 20, 9:00 AM

Formatting.

Harbormaster completed remote builds in B25477: Diff 59706.Fri, Jan 20, 9:22 AM

Falk David (filedescriptor) mentioned this in D17063: Curves: Add initial transform support.Fri, Jan 20, 12:45 PM

Closed by commit rB70ca15670d9f: Curves: Edit mode selection operators (authored by Falk David (filedescriptor)). · Explain WhyFri, Jan 20, 4:41 PM

This revision was automatically updated to reflect the committed changes.

Falk David (filedescriptor) added a commit: rB70ca15670d9f: Curves: Edit mode selection operators.

Revision Contents
Changeset List

Path

Size

release/

scripts/

modules/

bl_keymap_utils/

keymap_hierarchy.py

1 line

rna_manual_reference.py

6 lines

presets/

keyconfig/

keymap_data/

blender_default.py

11 lines

startup/

bl_ui/

space_view3d.py

16 lines

source/

blender/

editors/

curves/

intern/

227 lines

curves_selection.cc

183 lines

include/

38 lines

sculpt_paint/

curves_sculpt_ops.cc

93 lines

space_api/

1 line

space_view3d/

space_view3d.cc

3 lines

Diff 59649

release/scripts/modules/bl_keymap_utils/keymap_hierarchy.py

Loading...

release/scripts/modules/rna_manual_reference.py

Loading...

release/scripts/presets/keyconfig/keymap_data/blender_default.py

Loading...

release/scripts/startup/bl_ui/space_view3d.py

Loading...

source/blender/editors/curves/intern/curves_ops.cc

Loading...

source/blender/editors/curves/intern/curves_selection.cc

Loading...

source/blender/editors/include/ED_curves.h

Loading...

source/blender/editors/sculpt_paint/curves_sculpt_ops.cc

Loading...

source/blender/editors/space_api/spacetypes.c

Loading...

source/blender/editors/space_view3d/space_view3d.cc

Loading...