Differential D17050

Fix anisotropic Beckmann regression test failing on Metal
ClosedPublic
Actions

Authored by Weizhen Huang (weizhen) on Thu, Jan 19, 8:12 PM.

Tags

None

Subscribers

None

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Commits

rBf71bfe465538: Fix anisotropic Beckmann regression test failing on Metal

Summary

The lookup table method on CPU and the numerical root finding method on
GPU give quite different results. This commit deletes the Beckmann lookup
table and uses numerical root finding on all devices. For the numerical
root finding, a combined bisection-Newton method with precision control
is used.

Diff Detail

Repository

Branch

master

Build Status

Buildable 25471
Build 25471: arc lint + arc unit

Event Timeline

Weizhen Huang (weizhen) requested review of this revision.Thu, Jan 19, 8:12 PM

Weizhen Huang (weizhen) created this revision.

Harbormaster completed remote builds in B25471: Diff 59670.Thu, Jan 19, 8:12 PM

Weizhen Huang (weizhen) added reviewers: Sergey Sharybin (sergey), Brecht Van Lommel (brecht).Thu, Jan 19, 8:13 PM

Brecht Van Lommel (brecht) accepted this revision.Thu, Jan 19, 8:27 PM

This revision is now accepted and ready to land.Thu, Jan 19, 8:27 PM

Closed by commit rBf71bfe465538: Fix anisotropic Beckmann regression test failing on Metal (authored by Weizhen Huang (weizhen)). · Explain WhyThu, Jan 19, 8:36 PM

This revision was automatically updated to reflect the committed changes.

Weizhen Huang (weizhen) added a commit: rBf71bfe465538: Fix anisotropic Beckmann regression test failing on Metal.

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

closure/

bsdf_microfacet.h

53 lines

5 lines

scene/

4 lines

128 lines

Diff 59670

intern/cycles/kernel/closure/bsdf_microfacet.h

Loading...

intern/cycles/kernel/types.h

Loading...

intern/cycles/scene/shader.h

Loading...

intern/cycles/scene/shader.cpp

Loading...