Fix: Draw: Negative scaled objects cause wrong resource indexing
ClosedPublic
Actions

Authored by Miguel Pozo (pragma37) on Fri, Jan 20, 5:19 PM.

Details

Reviewers

Clément Foucault (fclem)

Commits

rBb44a8f6749a5: Fix: Draw: Negative scaled objects cause wrong resource indexing

Summary

In the new Draw Manager, when the same DrawGroup has both front and back facing instances, the front facing instances don't offset their indices accordingly.

Diff Detail

Repository: rB Blender

Event Timeline

Miguel Pozo (pragma37) requested review of this revision.Fri, Jan 20, 5:19 PM

Miguel Pozo (pragma37) created this revision.

Harbormaster completed remote builds in B25489: Diff 59731.Fri, Jan 20, 5:19 PM

Test file:

D17069.blend841 KBDownload

This needs to follow the same logic as backfacing command and increment _instance_first_array when not an indexed draw.

This revision now requires changes to proceed.Fri, Jan 20, 9:58 PM

Fix non-indexed drawing

Harbormaster completed remote builds in B25521: Diff 59807.Mon, Jan 23, 4:43 PM

Clément Foucault (fclem) accepted this revision.Mon, Jan 23, 4:53 PM

This revision is now accepted and ready to land.Mon, Jan 23, 4:53 PM

Closed by commit rBb44a8f6749a5: Fix: Draw: Negative scaled objects cause wrong resource indexing (authored by Miguel Pozo (pragma37)). · Explain WhyMon, Jan 23, 4:55 PM

This revision was automatically updated to reflect the committed changes.

Miguel Pozo (pragma37) added a commit: rBb44a8f6749a5: Fix: Draw: Negative scaled objects cause wrong resource indexing.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

shaders/

draw_command_generate_comp.glsl

11 lines

Diff 59808

View Options

source/blender/draw/intern/shaders/draw_command_generate_comp.glsl

Fix: Draw: Negative scaled objects cause wrong resource indexingClosedPublicActions