Page MenuHome
Differential D17103

Fix T104044: keep order of UVMaps on load
ClosedPublic
Actions

Authored by Martijn Versteegh (Baardaap) on Tue, Jan 24, 11:18 AM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Maniphest Tasks
T104044: Regression: UVMap channels order breaks after scene reload
Commits
rBa73a2d345fff: Fix T104044: keep order of UVMaps on load
Summary

Use a Vector<std::string> , instead of a Set<std::string> as a Set does
not keep the same order when iterating over it.

Diff Detail

Repository
rB Blender

Event Timeline

Martijn Versteegh (Baardaap) requested review of this revision.Tue, Jan 24, 11:18 AM
Martijn Versteegh (Baardaap) created this revision.
Martijn Versteegh (Baardaap) added a task: T104044: Regression: UVMap channels order breaks after scene reload.
Iliya Katueshenock (Moder) added a subscriber: Iliya Katueshenock (Moder).Tue, Jan 24, 11:21 AM

I can't see context, but if really important to find strings by hash in container and save order of appending, so you can also look at VectorSet

Martijn Versteegh (Baardaap) added a reviewer: Hans Goudey (HooglyBoogly).Tue, Jan 24, 11:22 AM
Martijn Versteegh (Baardaap) added a comment.Tue, Jan 24, 11:24 AM
In D17103#466343, @Iliya Katueshenock (Moder) wrote:

I can't see context, but if really important to find strings by hash in container and save order of appending, so you can also look at VectorSet

I think a Set was the wrong choice anyway. A Set is useful for quick lookup I think, but I just need to iterate over it.

Jacques Lucke (JacquesLucke) accepted this revision.Tue, Jan 24, 4:14 PM
This revision is now accepted and ready to land.Tue, Jan 24, 4:14 PM
Hans Goudey (HooglyBoogly) accepted this revision.Tue, Jan 24, 5:44 PM
Closed by commit rBa73a2d345fff: Fix T104044: keep order of UVMaps on load (authored by Martijn Versteegh (Baardaap)). · Explain WhyTue, Jan 24, 6:31 PM
This revision was automatically updated to reflect the committed changes.
Martijn Versteegh (Baardaap) added a commit: rBa73a2d345fff: Fix T104044: keep order of UVMaps on load.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
4 lines

Diff 59874

View Options

source/blender/blenkernel/intern/mesh_legacy_convert.cc

Loading...