Page MenuHome
Differential D17119

Draw: Improve Texture assignment operator
ClosedPublic
Actions

Authored by Miguel Pozo (pragma37) on Wed, Jan 25, 4:40 PM.

Details

Reviewers
Clément Foucault (fclem)
Commits
rBe744673268a1: Draw: Improve Texture assignment operator
Summary

The *this caused a cast to GPUTexture, so it was not possible to do a copy assignment to textures when tx_ was null.
This change also transfers all the copied contents and ensures the previous ones get freed.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 25563
Build 25563: arc lint + arc unit

Event Timeline

Miguel Pozo (pragma37) requested review of this revision.Wed, Jan 25, 4:40 PM
Miguel Pozo (pragma37) created this revision.
Harbormaster completed remote builds in B25563: Diff 59914.Wed, Jan 25, 4:40 PM
Miguel Pozo (pragma37) edited the summary of this revision. (Show Details)Wed, Jan 25, 4:53 PM
Clément Foucault (fclem) accepted this revision.Wed, Jan 25, 5:00 PM
This revision is now accepted and ready to land.Wed, Jan 25, 5:00 PM
Closed by commit rBe744673268a1: Draw: Improve Texture assignment operator (authored by Miguel Pozo (pragma37)). · Explain WhyWed, Jan 25, 5:13 PM
This revision was automatically updated to reflect the committed changes.
Miguel Pozo (pragma37) added a commit: rBe744673268a1: Draw: Improve Texture assignment operator.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
intern/
12 lines

Diff 59914

View Options

source/blender/draw/intern/DRW_gpu_wrapper.hh

Loading...