Cycles: Use special debug panel to fine-tune debug flags
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jan 9 2016, 12:54 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Thomas Dinges (dingto)
Lukas Stockner (lukasstockner97)
Martijn Berger (juicyfruit)

Commits

rC84781f5394cb: Use special debug panel to fine-tune debug flags
rBSac7aefd7c2bc: Cycles: Use special debug panel to fine-tune debug flags
rBac7aefd7c2bc: Cycles: Use special debug panel to fine-tune debug flags

Summary

This panel is only visible when debug_value is set to 256 and has no
affect in other cases. However, if debug value is not set to this
value, environment variables will be used to control which features
are enabled, so there's no visible changes to anyone in fact.

There are some changes needed to prevent devices re-enumeration on
every Cycles session create.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) updated this revision to Diff 5775.Jan 9 2016, 12:54 PM

Sergey Sharybin (sergey) retitled this revision from to Cycles: Use special debug panel to fine-tune debug flags.

Sergey Sharybin (sergey) added reviewers: Brecht Van Lommel (brecht), Martijn Berger (juicyfruit), Lukas Stockner (lukasstockner97), Thomas Dinges (dingto).

Sergey Sharybin (sergey) updated this object.

Nice patch, seems useful for debugging!
Another option that might be useful for debugging/benchmarking would be a Tile Size and Samples override via environment variables, but that's probably out of scope for this patch.

intern/cycles/device/device.h
193	Diff Noise
intern/cycles/util/util_debug.cpp
38	Am I missing something or is GLUE unused?

This revision is now accepted and ready to land.Jan 9 2016, 1:11 PM

Cleanup for the review from Lukas

As for the samples override -- this should be done in the same way as "progressive samples" option which i need to extract from Gooseberry branch in a nice way. Tile size -- not so sure that much, you can do:

blender --python-expr="import bpy; bpy.data.scenes['foo'].render.tile_x = 100; bpy.data.scenes['foo'].render.tile_y = 200"

Don't really think we should add environment variables for the stuff which we can control via RNA.

intern/cycles/device/device.h
193	Removed.
intern/cycles/util/util_debug.cpp
38	Yes, was used in intermediate path version. Unneeded now. Removed.

Why not use --debug-cycles to enable this?

The idea was to avoid need of any terminal/commandline magic for users. So we can easily ask reporters to test something without describing what the command line is and what exactly to type in there.

Another side, is that one might not really want the intense logging and only wants to tweak some values in order to test particular stuff.

Ok, fair enough.