Fix: Video Sequencer "Pan" label using incorrect keyword 'heading_ctxt'
AcceptedPublic
Actions

Authored by Kevin C. Burke (blastframe) on Mon, Feb 6, 9:31 AM.

Details

Reviewers

Richard Antalik (ISS)

Summary

This patch fixes a bug in the Video Sequencer's user interface.

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 528.24

Blender Version
Broken: version: 3.5.0 Alpha, branch: master, commit date: 2023-02-06 03:26, hash: rB329eeacc66d1

Short description of error
The Video Sequencer's "Pan" label using incorrect keyword 'heading_ctxt'

Exact steps for others to reproduce the error

Create/switch to a Video Editing Workspace
In the Video Sequencer > Add > Sound

In the Python Console:

Traceback (most recent call last):
  File "C:\blender-git\build_windows_x64_vc17_Release\bin\Release\3.5\scripts\startup\bl_ui\space_sequencer.py", line 1999, in draw
    split.label(text="Pan", heading_ctxt=i18n_contexts.id_sound)
TypeError: UILayout.label(): was called with invalid keyword argument(s) (heading_ctxt), expected (text, text_ctxt, translate, icon, icon_value)

Diff Detail

Repository: rB Blender

Event Timeline

Kevin C. Burke (blastframe) requested review of this revision.Mon, Feb 6, 9:31 AM

Kevin C. Burke (blastframe) created this revision.

Kevin C. Burke (blastframe) added reviewers: Video Sequencer, User Interface.

Kevin C. Burke (blastframe) edited the summary of this revision. (Show Details)

Kevin C. Burke (blastframe) retitled this revision from Bug Fix: Video Sequencer "Pan" label using incorrect keyword 'heading_ctxt' to Fix: Video Sequencer "Pan" label using incorrect keyword 'heading_ctxt'.Mon, Feb 6, 9:34 AM

Thanks for patch!
Please note, that patch description should read as commit message (see https://wiki.blender.org/wiki/Process/Contributing_Code).

In this case it could be as simple as "Oversight in db87e2a638f9"

This revision is now accepted and ready to land.Mon, Feb 6, 3:01 PM

@Richard Antalik (ISS) Thank you for the message and link. I read Contributing_Code again, but could you please clarify what you took issue with in Fix: Video Sequencer "Pan" label using incorrect keyword 'heading_ctxt'?

Going by the Commit Messages article

It's less than 72 characters (71)
It explains exactly what the problem was. "Oversight in db87e2a638f9" does not do this.
It does not explain what was fixed on a user level. Is this the issue? "Oversight in db87e2a638f9" does not do this either.
It starts with "Fix:"

Any help will be appreciated and useful for future patches. Thank you!

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_sequencer.py

2 lines

Diff 60273

View Options

release/scripts/startup/bl_ui/space_sequencer.py

Fix: Video Sequencer "Pan" label using incorrect keyword 'heading_ctxt'AcceptedPublicActions