This is the patch for T42004. This patch and the task kinda rot, so at last I upload this patch in order to perhaps get things going here.
Here's a screenshot:
Details
Details
- Reviewers
Brecht Van Lommel (brecht) Thomas Dinges (dingto) - Group Reviewers
User Interface - Maniphest Tasks
- T42004: Improve Progress Bar Design
- Commits
- rBSc6bc2363e5ec: UI: redesign of the progress bar.
rBc6bc2363e5ec: UI: redesign of the progress bar.
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- progress_bar
Event Timeline
| source/blender/editors/interface/interface_templates.c | ||
|---|---|---|
| 3349–3379 | For render progress timing we already have BLI_timecode_string_from_time_simple(). This new format is easier to understand, but I think we should try to be consistent. If we want to make an easier to understand time format that can be done as a separate task for Blender as a whole. For backwards compatibility that might have to wait for 2.8 though, some scripts might be parsing the time format from logs. | |
| source/blender/editors/interface/interface_widgets.c | ||
| 1857 | This theme color change will not affect existing user preferences. We should version patch this in init_userdef_do_versions(). | |
| source/blender/editors/render/render_internal.c | ||
| 948–949 | Not sure why this change was done, but if we do it then "Sequence Render"` should be changed too. | |
| source/blender/windowmanager/intern/wm_jobs.c | ||
| 280 | Use sizeof(wm_job->text) instead of 128. | |
Comment Actions
- Address review points
- use PIL_time
- de-duplicate "start_time" property from wmJob struct
| source/blender/editors/render/render_internal.c | ||
|---|---|---|
| 948–949 | This was to align with the mockup I used, iirc. It does make sense since technically at this point Blender, or rather the render engine, is "rendering". I would say that if we do it, then we should be total grammar nazis and rework all of the other job names to be like that (i.e. "Fluid Simulation" -> "Simulating Liquid" (smoke/gas is a fluid too!)). Then with D1731, we'd also have to associate the correct cache name with the job instead of simply "Point Cache". Anyway, that out of the scope of this patch I guess, so I'm gonna revert this little change. | |
Comment Actions
Looks good to me now except one thing, when rendering is see "Rend" instead of "Render" as the text, not sure where those characters get cut off.
Comment Actions
Subversion bump needs update for master, apart from that it compiles fine. I am fine with it.