Manipulator User Preference unit and tooltip fixes; removal of x5 hardcoded size multiplier; version switch on size to handle earlier version preferences now not being multiplied.
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Jan 6 2014, 11:44 AM.

Details

Reviewers

• William Reynish (billrey)
Andrew Buttery (axb)

Summary

Added px to to widget size and % to widget handles properties; changed size tooltip; updated tooltips so all refer to the "manipulator" instead of some referring to "widget" - usage was inconsistent.

Removed hardcoded x5.0f size multiplier in transform_manipulator.c. Because of this also added in a version switch which will multiply pre-fix versions size preference by 5. Also increased the RNA defs for size range x 5 and default value for size x5 to allow for the removal of the hardcoded multiplier.

Please note that the revision requested by William has not been made as doing so will cause every percentage field in Blender to change from a slider to number format. See T38058 for more information on the broader impacts.

Translation impacts: Yes

Documentation impacts: Yes
http://wiki.blender.org/index.php/Doc:2.6/Manual/3D_interaction/Transform_Control/Manipulators

http://wiki.blender.org/index.php/Doc:2.4/Manual/3D_interaction/Transform_Control/Manipulators - will not be updated v2.4

I will do the wiki updates once the change is committed.

andrew

Diff Detail

Event Timeline

Nice, seems good.

On second thought, the Handle Size % seems strange. it Only goes up to 40%, but the slider makes it look like it's a larger percentage than that.

I see two options:

Make the Handle Size parameter go from 0-100%, even if 100% probably doesn't make much sense
Don't use a slider (but still keep the %)

Either of these I think would be fine

• William Reynish (billrey) requested changes to this revision.Jan 6 2014, 5:42 PM

Some comments on versioning userprefs.

source/blender/editors/interface/resources.c
1472	You should be able to leave this as is, and allow the `* 5` to run later on in the function. This overwrites the existing size, in this case its not really a big deal, but can be avoided.
1479	Bump the `BLENDER_SUBVERSION` instead, then check `if (!MAIN_VERSION_ATLEAST(main, 269, 9)) {` ... `*= 5` ... `}`