Point Cache: use job system for bake operators.
ClosedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on Jan 12 2016, 5:12 PM.

Details

Reviewers

Commits

rBS45b6893e7045: Point Cache: use job system for bake operators.
rB45b6893e7045: Point Cache: use job system for bake operators.

Summary

As in the title.

Diff Detail

Repository: rB Blender

Event Timeline

Kévin Dietrich (kevindietrich) updated this revision to Diff 5811.Jan 12 2016, 5:12 PM

Kévin Dietrich (kevindietrich) retitled this revision from to Point Cache: use job system for bake operators..

Kévin Dietrich (kevindietrich) updated this object.

Brecht Van Lommel (brecht) added a reviewer: Brecht Van Lommel (brecht).Jan 13 2016, 12:58 AM

It's not thread safe to let the user edit the scene while baking is in progress, try deleting all objects in the scene while it's baking for example. So while using the jobs system is a nice improvement, this still must be a blocking operation.

You could use WM_set_locked_interface to do that (but not make it optional as it is for rendering).

source/blender/blenkernel/intern/pointcache.c
3120	Add `baker.bake_job = NULL;` here.
3246–3294	I think launching this thread is unnecessary since `BKE_ptcache_bake` now always runs as part of a job. So probably this code could be simplified. You can do it as part of this patch or leave a comment in the code for someone to do it later.
source/blender/render/intern/source/pipeline.c
3053–3054	Same.