Details

Reviewers

Thomas Beck (plasmasolutions)
Gottfried Hofmann (gottfried)

Commits

rBSb6d35e1fa740: Viewport smoke: add support to render the volume using a color ramp.
rBS14e825aa1fb5: Viewport smoke: add options to draw velocity vectors.
rBS4446acbf1774: Viewport smoke: add support for axis aligned slicing.
rBb6d35e1fa740: Viewport smoke: add support to render the volume using a color ramp.
rB14e825aa1fb5: Viewport smoke: add options to draw velocity vectors.
rB4446acbf1774: Viewport smoke: add support for axis aligned slicing.

Summary

NOTE: This is not really ready for code review, just uploading this here for general feedback on tools, what's desired or not, what else could be done, etc..

This introduces a number of "tools" to visualize a smoke sim in different ways.

Included changes are:

Object (axis) aligned slicing.
Single slice visualization.
Transfer function based on a color ramp.
Control of the apparent thickness of the volume.
Visualize the velocity field as a set of needles or streamlines

The overall number of slices can be set on a "per voxel" (smoke resolution) basis, meaning that if the resolution is set to 32, there will be slice_per_voxel * 32 slices in total.

Diff Detail

Repository

rB Blender

Branch

smoke_vis_tools

Build Status

Buildable 40
Build 40: arc lint + arc unit

Event Timeline

Kévin Dietrich (kevindietrich) updated this revision to Diff 5813.Jan 12 2016, 9:28 PM

Kévin Dietrich (kevindietrich) retitled this revision from to Smoke/volume visualization settings.

Kévin Dietrich (kevindietrich) added reviewers: Thomas Beck (plasmasolutions), Gottfried Hofmann (gottfried).

Kévin Dietrich (kevindietrich) updated this object.

Here are a couple of screenshots:

Lukas Tönne (lukastoenne) awarded a token.Jan 13 2016, 12:34 PM

Lukas Tönne (lukastoenne) added a subscriber: Lukas Tönne (lukastoenne).Jan 13 2016, 2:10 PM

mathieu menuet (bliblubli) awarded a token.Jan 13 2016, 7:05 PM

Matt Heimlich (m9105826) added a subscriber: Matt Heimlich (m9105826).Jan 17 2016, 11:11 PM

Add a function to compute volume normal.
Rework UI a bit.
Add automatic axis detection for single slice mode.
Make sure display thickness is always initialized.

Add a function to compute volume normal.
Rework UI a bit.
Add automatic axis detection for single slice mode.
Make sure display thickness is always initialized.
Add support to draw the velocity field as needles.
De-duplicate logic behing transfer function creation.
Add support to draw velocity vector as needles.

Hi Kevin, just came back from business trip - will now test it. Could you lift line 390 to 389 (rna_smoke.c) next time you update the patch? The #endif is one line too low...

Will report back once I tested a bit..

Oops, wonder how that got in... will quickly update the patch, just in case.

Fix compile error.

Kévin Dietrich (kevindietrich) updated this object.Jan 27 2016, 12:15 AM

@Thomas Beck (plasmasolutions), @Gottfried Hofmann (gottfried), do you guys have any comment on the (basic) functionalities introduced here? I'm particularly concerned about the color ramp thing, since it interfere with fire rendering. Otherwise, I'll try to find some core developers willing to review the code.

Hi @Kévin Dietrich (kevindietrich),

this is definitely useful! Not only to visualize smoke (& its behaviour) in the viewport better but also because we render smoke oftentimes in the viewport and composit it over footage. The different visualization options are very helpful in this regard. Especially the "Axis / Single / Position" option is awesome for 2D scenes. What I didn't get yet was how to control the color ramp though. I could only make some single colored smoke (with various alpha values but no different colors)... will try to contact you in IRC - maybe it's just a dumb user error..

The draw velocity options were not used that much up until now in my studio - but maybe when we have errors in the simulation that we can't track they come in handy (btw. the hard limit of 10 was way too less in almost all of our simulations).

So all in all a definite YES for these features (except the - it's really great!

I did not find time yet to apply the patch myself - in what way does the patch interfere with fire rendering?

Colorramp is useful but not easy to use. Here, it controls two things.
It gives colors accordding to density and acts as a density multiplier according to alpha values.
Problem is that when you change position of a stop to change color, alpha value position used as a density multiplier is changed too.

Probably, it would be better to have a custom curve widget for density like in freestyle linestyle alpha modifiers and have no effect from alpha values of ramp.
Sometimes, I think that a levels of grey ramp widget would be more adapted than curve widget.

Use of color ramp implies a rendering based on density.
If colors can be decoupled from density, is it possible to have menu to tweak color according to another smoke attribute like heat ?
I am not requesting several color tweakings that would be mixed on final display.
I am just saying that (except velocity that have a great line display), each attribute could benefit of a study through colors.

Smoke color is default display but it is not tweakable, too. We can't try to reduce it or push it in viewport. It is thomas problem about several flows.
Could it be possible to have a Hue Correct widget for this one ?

Sebastián Barschkis (sebbas) added a subscriber: Sebastián Barschkis (sebbas).Jul 13 2016, 10:09 PM

This patch kinda rot, but I'm not given up on it ;)

I just set the hard limit of some properties to 1000.0 instead of 10.0 (hopefully that's enought) and I also added access to the various fluid fields:

Also updated against latest head.

Merge branch 'master' into smoke_vis_tools
Cleanup: avoid using sets.
Fix compile error.
Cleanup.
Expose all fluid fields to the UI.
Fix drawing of the transfer texture.
Rework default values, UI/props ranges.
Add some tooltips, remove some fields in the UI.

Revert a few changes from master.
Remove compute_normals from shader.
Use more sane variable names.
Cleanup.

Closed by commit rB4446acbf1774: Viewport smoke: add support for axis aligned slicing. (authored by Kévin Dietrich (kevindietrich)). · Explain WhySep 24 2016, 10:39 PM

Closed by commit rB14e825aa1fb5: Viewport smoke: add options to draw velocity vectors. (authored by Kévin Dietrich (kevindietrich)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Note that I haven't committed the color ramp part of the patch since I'm a little hesitating about its usefulness, though I can still commit it as is if people really want it.

filip mond (vklidu) awarded a token.Sep 26 2016, 7:17 PM

Since viewport is maintained in these days, I hope color-ramp would be one of the great features for better vusializations and rendering smoke directly from viewport.

I committed the ability to use a color ramp for rendering. Note that it turns off fire rendering.

Smoke/volume visualization settings
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 7114

intern/smoke/intern/FLUID_3D.h

intern/smoke/intern/FLUID_3D.cpp

release/scripts/startup/bl_ui/properties_physics_smoke.py

source/blender/blenkernel/BKE_DerivedMesh.h

source/blender/blenkernel/intern/DerivedMesh.c

source/blender/blenkernel/intern/smoke.c

source/blender/blenlib/BLI_math_color.h

source/blender/blenlib/intern/math_color.c

source/blender/blenloader/intern/readfile.c

source/blender/blenloader/intern/versioning_270.c

source/blender/blenloader/intern/writefile.c

source/blender/editors/space_view3d/drawobject.c

source/blender/editors/space_view3d/drawvolume.c

source/blender/editors/space_view3d/view3d_intern.h

source/blender/gpu/GPU_shader.h

source/blender/gpu/intern/gpu_shader.c

source/blender/gpu/shaders/gpu_shader_smoke_frag.glsl

source/blender/makesdna/DNA_smoke_types.h

source/blender/makesrna/intern/rna_smoke.c

Smoke/volume visualization settingsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7114

intern/smoke/intern/FLUID_3D.h

intern/smoke/intern/FLUID_3D.cpp

release/scripts/startup/bl_ui/properties_physics_smoke.py

source/blender/blenkernel/BKE_DerivedMesh.h

source/blender/blenkernel/intern/DerivedMesh.c

source/blender/blenkernel/intern/smoke.c

source/blender/blenlib/BLI_math_color.h

source/blender/blenlib/intern/math_color.c

source/blender/blenloader/intern/readfile.c

source/blender/blenloader/intern/versioning_270.c

source/blender/blenloader/intern/writefile.c

source/blender/editors/space_view3d/drawobject.c

source/blender/editors/space_view3d/drawvolume.c

source/blender/editors/space_view3d/view3d_intern.h

source/blender/gpu/GPU_shader.h

source/blender/gpu/intern/gpu_shader.c

source/blender/gpu/shaders/gpu_shader_smoke_frag.glsl

source/blender/makesdna/DNA_smoke_types.h

source/blender/makesrna/intern/rna_smoke.c

Smoke/volume visualization settings
ClosedPublic
Actions

Revision Contents
Changeset List