Fix T47198: Broken UV/VCol in BI and Cycles with some degenerated faces.
AbandonedPublic
Actions

Authored by Bastien Montagne (mont29) on Jan 19 2016, 7:40 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Thomas Dinges (dingto)
Sergey Sharybin (sergey)

Maniphest Tasks

T47198: Cycles & BI have broken UVs in some degenerated quads cases

Summary

Problem is actually similar in both engines - in some cases, we changed
'natural' quad splitting order to alternative one, without properkly 'notifying'
UV/VCol/other tessface data about it.

So code would use a 'wrong' triangle of UVs etc.

Solution for BI is rather simple and hopefully does not break anything.

Solution for Cycles is not so elegant imho, but coul not imagine a better way to do it...

Diff Detail

Repository: rB Blender
Branch: t47198

Event Timeline

Bastien Montagne (mont29) updated this revision to Diff 5877.Jan 19 2016, 7:40 PM

Bastien Montagne (mont29) added a task: T47198: Cycles & BI have broken UVs in some degenerated quads cases.

Bastien Montagne (mont29) retitled this revision from to Fix T47198: Broken UV/VCol in BI and Cycles with some degenerated faces..

Bastien Montagne (mont29) added reviewers: Sergey Sharybin (sergey), Brecht Van Lommel (brecht), Thomas Dinges (dingto).

Bastien Montagne (mont29) updated this object.

Sergey Sharybin (sergey) mentioned this in rBa6eae7339190: Fix (partial) T47198: Cycles have broken UVs in some degenerated quads cases.Jan 20 2016, 9:15 AM

Blender internal side looks fine. Cycles part i was not happy about with all this magic of using negative nverts to indicate some special condition. Added a per-face flag now and added some utility function to get triangles split, so we don't duplicate logic that much.

Those changes are committed at rBa6eae73. Please go ahead with the BI side.

This revision is now accepted and ready to land.Jan 20 2016, 9:17 AM

Sergey Sharybin (sergey) added inline comments.Jan 20 2016, 9:18 AM