Page MenuHome
Differential D1750

T37875 - some additional options
ClosedPublic
Actions

Authored by Michał Ziobro (Muchomor) on Jan 28 2016, 12:51 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T37875: Select Similar for Bones, more options
Commits
rBSa92bdfe0c917: Armature select similar: children, immediate-children en sibligns selection.
rBa92bdfe0c917: Armature select similar: children, immediate-children en sibligns selection.
Summary

I created few additional options for selecting similar bones in edit mode.

Diff Detail

Repository
rB Blender

Event Timeline

Michał Ziobro (Muchomor) updated this revision to Diff 5917.Jan 28 2016, 12:51 PM
Michał Ziobro (Muchomor) retitled this revision from to T37875 - some additional options.
Michał Ziobro (Muchomor) updated this object.
Michał Ziobro (Muchomor) set the repository for this revision to rB Blender.
Michał Ziobro (Muchomor) added a reviewer: Brecht Van Lommel (brecht).
Michał Ziobro (Muchomor) added a project: BF Blender.
Michał Ziobro (Muchomor) added a subscriber: Brecht Van Lommel (brecht).
Michał Ziobro (Muchomor) mentioned this in T37875: Select Similar for Bones, more options.Jan 28 2016, 12:55 PM
Michał Ziobro (Muchomor) added a task: T37875: Select Similar for Bones, more options.Jan 28 2016, 6:20 PM
Brecht Van Lommel (brecht) requested changes to this revision.Jan 30 2016, 2:01 PM
Brecht Van Lommel (brecht) edited edge metadata.
Brecht Van Lommel (brecht) added a subscriber: Campbell Barton (campbellbarton).

Thanks! I only have some minor nitpicks, the functionality seems to work fine.

@Campbell Barton (campbellbarton), I think you added this to the quick hacks list initially, maybe you have some comments.

source/blender/editors/armature/armature_select.c
864

This function should be static.

865

Style: put return; on a new line, and without the space between.

884

Style, use space: EBONE_SELECTABLE(arm, ebone_iter)

893

Same style note as above.

903

Same style note as above.

906

Same style note as above.

This revision now requires changes to proceed.Jan 30 2016, 2:01 PM
Michał Ziobro (Muchomor) updated this revision to Diff 5933.Jan 30 2016, 2:51 PM
Michał Ziobro (Muchomor) edited edge metadata.

Hmm, I think it's fixed.

Brecht Van Lommel (brecht) accepted this revision.Jan 30 2016, 3:18 PM
Brecht Van Lommel (brecht) edited edge metadata.

Looks good, I'll commit this soon if there are no further comments from others.

This revision is now accepted and ready to land.Jan 30 2016, 3:18 PM
Closed by commit rBa92bdfe0c917: Armature select similar: children, immediate-children en sibligns selection. (authored by Michał Ziobro (Muchomor), committed by Brecht Van Lommel (brecht)). · Explain WhyFeb 2 2016, 12:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
armature/
68 lines

Diff 5937

View Options

source/blender/editors/armature/armature_select.c

Loading...