Page MenuHome

Custom shape select in pose mode.
AbandonedPublic

Authored by Michał Ziobro (Muchomor) on Feb 10 2016, 10:38 AM.

Details

Summary

Select group had been already done, so I added custom shape option only.
It's a bit strange, that this select works quite different than similar thing in edit mode
(selection based on selected items, not on active one).

Diff Detail

Repository
rB Blender

Event Timeline

Campbell Barton (campbellbarton) requested changes to this revision.Feb 10 2016, 10:54 AM
Campbell Barton (campbellbarton) edited edge metadata.
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/armature/pose_select.c
803

SmallHash is mainly for cases when we want to avoid allocs, and when there are very few elements in the hash. Otherwise its generally better to use GHash. (For this patch please use GHash)

Note that in this case you could flag use a temporary flag on objects, but using a hash is OK since it can be more easily extended for different kinds of properties without each function needing to have different logic.

This revision now requires changes to proceed.Feb 10 2016, 10:54 AM
Michał Ziobro (Muchomor) updated this revision to Diff 6034.EditedFeb 10 2016, 12:03 PM
Michał Ziobro (Muchomor) edited edge metadata.

Changed it to GHash (as GSet, it's probably more appropriate in this case)

Should I also add options like children/siblings also to Pose Mode?
Or add possibility of using only active bone?