Page MenuHome
Differential D1845

Include requests' cacert.pem file
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on Mar 10 2016, 4:59 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Martijn Berger (juicyfruit)
Maniphest Tasks
T48348: cacert.pem is not included in Windows and MacOS builds
Commits
rBSa5bc674e8856: Include requests' cacert.pem file
rBa5bc674e8856: Include requests' cacert.pem file
rBS9f8311ee8871: Include requests' cacert.pem file
rB9f8311ee8871: Include requests' cacert.pem file
Summary

This allows us to verify certificates of HTTPS connections, which is
mandatory for logins like on Blender ID.

Diff Detail

Repository
rB Blender

Event Timeline

Sybren A. Stüvel (sybren) updated this revision to Diff 6232.Mar 10 2016, 4:59 PM
Sybren A. Stüvel (sybren) retitled this revision from to Include requests' cacert.pem file.
Sybren A. Stüvel (sybren) added a reviewer: Campbell Barton (campbellbarton).
Sybren A. Stüvel (sybren) updated this object.
Martijn Berger (juicyfruit) accepted this revision.Mar 10 2016, 5:03 PM
Martijn Berger (juicyfruit) added a reviewer: Martijn Berger (juicyfruit).
Martijn Berger (juicyfruit) added a subscriber: Martijn Berger (juicyfruit).

Seems we need it.

We need to keep requests up to date when doing this.

This revision is now accepted and ready to land.Mar 10 2016, 5:03 PM
Campbell Barton (campbellbarton) accepted this revision.Mar 11 2016, 7:56 AM
Campbell Barton (campbellbarton) edited edge metadata.

Originally I didn't want to have Blender dealing with security (as in - have to update builds whenever new certificates are released).

But think its fine to include, since its expected to use requests in many cases.

Closed by commit rB9f8311ee8871: Include requests' cacert.pem file (authored by Sybren A. Stüvel (sybren)). · Explain WhyMar 11 2016, 7:58 AM
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) mentioned this in T48348: cacert.pem is not included in Windows and MacOS builds.May 3 2016, 4:53 PM
Sybren A. Stüvel (sybren) added a task: T48348: cacert.pem is not included in Windows and MacOS builds.
Sybren A. Stüvel (sybren) mentioned this in rBL61656: Added cacert.pem from requests-2.10.0, for D1845.May 3 2016, 5:04 PM

Revision Contents
Changeset List

PathSize
source/
creator/
1 line

Diff 6234

View Options

source/creator/CMakeLists.txt

Loading...