possible fix for T47770
remove all members of a metaball 'family' upon conversion to mesh
Details
Details
- Reviewers
Bastien Montagne (mont29)
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Besides points noted below, patch looks OK to me, @Campbell Barton (campbellbarton) probably wants to check it too though.
| source/blender/editors/object/object_add.c | ||
|---|---|---|
| 1742 | We try to avoid those 'private' markers (the _ prepended to varnames) as much as possible, not needed here anyway… | |
| 1743 | You do not need base_next temp var at all here, since you do not free base, you can just do: for (Base *base_tmp = scene->base.first; base_tmp; base_tmp = base_tmp->next) {
...
} | |
Comment Actions
Just going through accepted but open patches... Not sure how to continue with this @Bastien Montagne (mont29)? Note that Campbell expressed concerns in T47770.
Comment Actions
Uh, yeah… think Campbell reasons make sense in T47770 in fact… so thanks for the patch, but will close it for now.