Differential D1867

Fix uneven rays bug on SimpleStar GlareNode
ClosedPublic
Actions

Authored by Matheus de Sousa Faria (MatheusFaria) on Mar 22 2016, 2:01 PM.

Tags

Subscribers

None

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Commits

rBSb7fb00f51271: Fix compositor Glare node with Simpler Star resulting in uneven rays.
rBb7fb00f51271: Fix compositor Glare node with Simpler Star resulting in uneven rays.

Summary

Currently when you use the Glare Node in Compositing, and chooses the type Simple Star, it produces a effect with uneven rays. (See: https://goo.gl/photos/YM4dKxB7NQctiDug6 )
That why the initialization of the second for-loop used on this node operation was wrong. I fixed it, and now it is producing the correct effect (See: https://goo.gl/photos/imPeh2adWgASZkpu6)

Diff Detail

Repository: rB Blender

Event Timeline

Matheus de Sousa Faria (MatheusFaria) updated this revision to Diff 6286.Mar 22 2016, 2:01 PM

Matheus de Sousa Faria (MatheusFaria) retitled this revision from to Fix uneven rays bug on SimpleStar GlareNode.

Matheus de Sousa Faria (MatheusFaria) updated this object.

Matheus de Sousa Faria (MatheusFaria) set the repository for this revision to rB Blender.

Matheus de Sousa Faria (MatheusFaria) added a project: Compositing.

Aaron Carlisle (Blendify) added reviewers: Campbell Barton (campbellbarton), Brecht Van Lommel (brecht), Sergey Sharybin (sergey).Jul 23 2017, 5:28 AM

Looks good to me, thanks for the patch!

This revision is now accepted and ready to land.Jul 25 2017, 12:39 AM

Closed by commit rBb7fb00f51271: Fix compositor Glare node with Simpler Star resulting in uneven rays. (authored by Matheus de Sousa Faria (MatheusFaria), committed by Brecht Van Lommel (brecht)). · Explain WhyJul 25 2017, 12:49 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

compositor/

operations/

COM_GlareSimpleStarOperation.cpp

4 lines

Diff 9023

source/blender/compositor/operations/COM_GlareSimpleStarOperation.cpp

Loading...