Page MenuHome
Differential D1915

Cycles: Microdisp - Migrate away from ccl::SubdMesh for tessellation
ClosedPublic
Actions

Authored by Mai Lavelle (maiself) on Apr 11 2016, 11:17 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Group Reviewers
Cycles
Commits
rBS665467e51eb4: Cycles microdisplacement: refactor to move some tesselation code from…
rC40bc49c42f47: Cycles microdisplacement: refactor to move some tesselation code from…
rB665467e51eb4: Cycles microdisplacement: refactor to move some tesselation code from…
Summary

ccl::SubdMesh was too sparse, and it helps to have direct access to ccl::Mesh

Diff Detail

Event Timeline

Mai Lavelle (maiself) updated this revision to Diff 6404.Apr 11 2016, 11:17 PM
Mai Lavelle (maiself) retitled this revision from to Cycles: Microdisp - Migrate away from ccl::SubdMesh for tessellation.
Mai Lavelle (maiself) updated this object.
Mai Lavelle (maiself) added a reviewer: Brecht Van Lommel (brecht).
Brecht Van Lommel (brecht) added a reviewer: Cycles.Apr 11 2016, 11:21 PM
Brecht Van Lommel (brecht) requested changes to this revision.Apr 11 2016, 11:26 PM
Brecht Van Lommel (brecht) edited edge metadata.

Only very minor comments, pretty much looks good to me.

intern/cycles/render/mesh.cpp
38–39

To match the convention, please add the ../sub directory in render/CMakeLists.txt, and then use #include "subd_split.h" here.

intern/cycles/render/mesh.h
31

This could be a class DiagSplit; forward declaration instead of an #include.

This revision now requires changes to proceed.Apr 11 2016, 11:26 PM
Mai Lavelle (maiself) updated this revision to Diff 6408.Apr 11 2016, 11:42 PM
Mai Lavelle (maiself) edited edge metadata.

Made requested changes

Brecht Van Lommel (brecht) accepted this revision.Apr 12 2016, 12:04 AM
Brecht Van Lommel (brecht) edited edge metadata.
This revision is now accepted and ready to land.Apr 12 2016, 12:04 AM
Closed by commit rB665467e51eb4: Cycles microdisplacement: refactor to move some tesselation code from… (authored by Mai Lavelle (maiself), committed by Brecht Van Lommel (brecht)). · Explain WhyApr 12 2016, 12:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
48 lines
render/
9 lines
51 lines

Diff 6404

View Options

intern/cycles/blender/blender_mesh.cpp

Loading...
View Options

intern/cycles/render/mesh.h

Loading...
View Options

intern/cycles/render/mesh.cpp

Loading...