Cycles Microdisp: Add max subdivision setting to subdivision meshes
ClosedPublic
Actions

Authored by Mai Lavelle (maiself) on Apr 13 2016, 11:51 AM.

Details

Reviewers

Brecht Van Lommel (brecht)

Group Reviewers

Cycles

Commits

rCf548a6a02b5b: Cycles microdisplacement: add max subdivision setting
rBS3068ea34e414: Cycles microdisplacement: add max subdivision setting
rB3068ea34e414: Cycles microdisplacement: add max subdivision setting

Summary

This is to prevent situations such as when the camera gets very close to a mesh and causes it to be tessellated into an excessive amount of micropolys.

I'm not sure about the default level, should it be higher or lower?

Diff Detail

Repository: rB Blender

Event Timeline

Mai Lavelle (maiself) updated this revision to Diff 6420.Apr 13 2016, 11:51 AM

Mai Lavelle (maiself) retitled this revision from to Cycles Microdisp: Add max subdivision setting to subdivision meshes.

Mai Lavelle (maiself) updated this object.

Mai Lavelle (maiself) added a reviewer: Brecht Van Lommel (brecht).

Brecht Van Lommel (brecht) added a reviewer: Cycles.Apr 14 2016, 12:18 AM

The implementation looks ok, but see D1919 about making this a scene level setting.

intern/cycles/subd/subd_split.cpp
115	Put `{` on new line to match the coding style convention.

This revision now requires changes to proceed.Apr 16 2016, 12:27 AM

@Brecht Van Lommel (brecht)

Should this setting be moved to the geometry panel or the simplify panel? Seems more like something for the simplify panel to me, but maybe you had a reason for wanting it in the geometry panel?

I'd move this to the geometry panel. It fits well there, similar to the Max Steps for Heterogenous Volume.

Yes, I think it should be in the Geometry panel because the settings in the Simplify panel only have an effect when you toggle Simplify on. Since this should always have an effect it belongs in the Geometry panel.