Page MenuHome
Differential D1989

Add Memory and Peak Memory as render stamp options
ClosedPublic
Actions

Authored by Lukas Stockner (lukasstockner97) on May 11 2016, 9:04 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Commits
rB3b43218af3cc: Add Peak Memory as render stamp option
rBS75a31c367022: Add Peak Memory as render stamp option
rB75a31c367022: Add Peak Memory as render stamp option
Summary

This commit adds Memory and Peak Memory to the stamp options, the values are the same ones
that are already shown in the image viewer.

Requested by @Ronny G (nutel).

Diff Detail

Repository
rB Blender

Event Timeline

Lukas Stockner (lukasstockner97) updated this revision to Diff 6655.May 11 2016, 9:04 PM
Lukas Stockner (lukasstockner97) retitled this revision from to Add Memory and Peak Memory as render stamp options.
Lukas Stockner (lukasstockner97) updated this object.
Lukas Stockner (lukasstockner97) added a subscriber: Ronny G (nutel).
Campbell Barton (campbellbarton) requested changes to this revision.May 16 2016, 3:31 PM
Campbell Barton (campbellbarton) added a reviewer: Campbell Barton (campbellbarton).
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

Seems OK, though not sure its worth having 2x options for this. Enabling memory could include both memory used and peak.

This revision now requires changes to proceed.May 16 2016, 3:31 PM
Ronny G (nutel) added a comment.May 17 2016, 5:23 PM

i think the peak value is enough just drop the memory option (?) :)

Lukas Stockner (lukasstockner97) updated this revision to Diff 6707.May 19 2016, 9:43 PM
Lukas Stockner (lukasstockner97) edited edge metadata.

I just removed the non-peak memory option for now, I suppose peak memory really is enough.

Brecht Van Lommel (brecht) accepted this revision.May 19 2016, 9:48 PM
Brecht Van Lommel (brecht) added a reviewer: Brecht Van Lommel (brecht).
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

The memory at the time stamping happens is indeed not very relevant, patch looks good to me.

Lukas Stockner (lukasstockner97) updated this revision to Diff 6708.May 19 2016, 10:22 PM
Lukas Stockner (lukasstockner97) edited edge metadata.

Fixed a typo in the code, forgot to test building before...

Closed by commit rB75a31c367022: Add Peak Memory as render stamp option (authored by Lukas Stockner (lukasstockner97)). · Explain WhyMay 19 2016, 10:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
1 line
source/
blender/
blenkernel/
intern/
30 lines
2 lines
makesdna/
3 lines
makesrna/
intern/
5 lines

Diff 6709

View Options

release/scripts/startup/bl_ui/properties_render.py

Loading...
View Options

source/blender/blenkernel/intern/image.c

Loading...
View Options

source/blender/blenkernel/intern/scene.c

Loading...
View Options

source/blender/makesdna/DNA_scene_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_scene.c

Loading...