Page MenuHome

Changing Select Random behaviour
AbandonedPublic

Authored by Campbell Barton (campbellbarton) on Jan 11 2014, 2:46 PM.

Diff Detail

Event Timeline

here it's applied only on the editmesh till its accepted ... after that the same changes will applied to the lattices, curves ... etc.

Walid Shouman (walid) updated this revision to Unknown Object (????).Jan 11 2014, 11:46 PM

Update the behaviour to the following

  • Curves
  • Objects
  • Lattices

Generally looks ok, about having switch inside the loop, IMHO it would be better to have ED_base_object_select(base, select); and similar for other modes, if we need to add a switch later for a 3rd action, it can be done at that time.

source/blender/editors/mesh/editmesh_select.c
2758

In this case you could use EDBM_deselect_flush / EDBM_select_flush which is simpler since we know the selection is only being added or removed.

source/blender/editors/object/object_lattice.c
203 ↗(On Diff #579)

This only needs to be done on de-selection, when adding to the selection the active element can stay.

Campbell Barton (campbellbarton) requested changes to this revision.Jan 12 2014, 5:47 AM
Walid Shouman (walid) updated this revision to Unknown Object (????).Jan 13 2014, 1:13 AM

Remove the switches out of the loops

Campbell Barton (campbellbarton) abandoned this revision.

Committed rB7ae1949517a41fbc46ca452f3fa40e7079273503 with some edits.

  • moved select_actions into a function.
  • changed loop/switch logic in places