Page MenuHome
Differential D2033

Fix wrong GLSL result for the camera data node's view vector in Cycles
ClosedPublic
Actions

Authored by Ralf Hölzemer (cheleb) on May 28 2016, 9:55 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB49ae0c50d947: Fix T48533: camera node view vector wrong for Cycles GLSL.
rBS739bf147a9f6: Fix T48533: camera node view vector wrong for Cycles GLSL.
rB739bf147a9f6: Fix T48533: camera node view vector wrong for Cycles GLSL.
Summary

See T48533 for details.

A modified test scene from the author of the report which also accounts for BI is attached here.

camera_vector_bug2.blend457 KBDownload

Diff Detail

Repository
rB Blender

Event Timeline

Ralf Hölzemer (cheleb) updated this revision to Diff 6799.May 28 2016, 9:55 AM
Ralf Hölzemer (cheleb) retitled this revision from to Fix wrong GLSL result for the camera data node's view vector in Cycles.
Ralf Hölzemer (cheleb) updated this object.
Ralf Hölzemer (cheleb) set the repository for this revision to rB Blender.
Ralf Hölzemer (cheleb) added projects: Nodes, GPU / Viewport.
Brecht Van Lommel (brecht) accepted this revision.May 28 2016, 11:35 AM
Brecht Van Lommel (brecht) added a reviewer: Brecht Van Lommel (brecht).
This revision is now accepted and ready to land.May 28 2016, 11:35 AM
Closed by commit rB739bf147a9f6: Fix T48533: camera node view vector wrong for Cycles GLSL. (authored by Ralf Hölzemer (cheleb), committed by Brecht Van Lommel (brecht)). · Explain WhyMay 28 2016, 11:44 AM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a comment.May 28 2016, 11:45 AM

Thanks for the fix and test file, Cycles indeed uses a different camera Z axis convention.

Bartosz Moniewski (monio) awarded a token.May 28 2016, 12:00 PM

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
shader/
nodes/
10 lines

Diff 6800

View Options

source/blender/nodes/shader/nodes/node_shader_camera.c

Loading...