Differential D2072

Fix input for Texture node (envmap+world_space_shading)
ClosedPublic
Actions

Authored by Alexander Romanov (a.romanov) on Jun 27 2016, 5:26 PM.

Details

Reviewers

Commits

rBS4aaf5baccf1b: Fix input for Texture node (envmap+world_space_shading)
rB4aaf5baccf1b: Fix input for Texture node (envmap+world_space_shading)

Summary

This patch fixes shortcoming of D2046.
The original behavior without world_space_shading flag is that Texture node expects the reflected vector in view space. But with world_space_shading it should be in world space.

In attached file you will see a simple material setup and a node material analogue.

Simple material must have the same behavior regardless world_space_shading flag.

node_mirror.blend2 MBDownload

Alexander (Blend4Web Team)

Diff Detail

Repository: rB Blender

Event Timeline

Alexander Romanov (a.romanov) updated this revision to Diff 6967.Jun 27 2016, 5:26 PM

Alexander Romanov (a.romanov) retitled this revision from to Fix input for Texture node (envmap+world_space_shading) .

Alexander Romanov (a.romanov) updated this object.

Alexander Romanov (a.romanov) updated this object.Jun 27 2016, 5:30 PM

Alexander Romanov (a.romanov) added a reviewer: Brecht Van Lommel (brecht).

Alexander Romanov (a.romanov) added subscribers: Yuri Kovelenov (yurikovelenov), Alexander Kovelenov (AlexKowel), Evgeny_Rodygin, Konstantin Khomyakov (homyachetser).

Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).Jun 28 2016, 2:48 AM

Campbell Barton (campbellbarton) added inline comments.

source/blender/render/intern/source/envmap.c
749	picky, Blender code uses space after if/switch/for... etc. Another case below.

fix style

Alexander Romanov (a.romanov) mentioned this in D2074: BI Viewport(GLSL): support for envmap in Texture node.Jun 28 2016, 1:53 PM

Brecht Van Lommel (brecht) accepted this revision.Jul 2 2016, 8:50 PM

Brecht Van Lommel (brecht) edited edge metadata.

This revision is now accepted and ready to land.Jul 2 2016, 8:50 PM

Closed by commit rB4aaf5baccf1b: Fix input for Texture node (envmap+world_space_shading) (authored by Alexander Romanov (a.romanov)). · Explain WhyJul 4 2016, 10:10 AM

This revision was automatically updated to reflect the committed changes.

Alexander Romanov (a.romanov) mentioned this in rBd4eb28ab7e48: BI Viewport(GLSL): support for envmap in Texture node.Jul 4 2016, 10:22 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

render/

intern/

source/

envmap.c

28 lines

render_texture.c

15 lines

Diff 6997

View Options

source/blender/render/intern/source/envmap.c