BI Viewport(GLSL): support for envmap in Texture node
ClosedPublic
Actions

Authored by Alexander Romanov (a.romanov) on Jun 28 2016, 1:49 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)

Commits

rBSd4eb28ab7e48: BI Viewport(GLSL): support for envmap in Texture node
rBd4eb28ab7e48: BI Viewport(GLSL): support for envmap in Texture node

Summary

This patch is another step to achieve BI and it's Viewport consistency for cubemap textures.

node_mirror.blend2 MBDownload

To test world_space_shading flag D2072 is required.

Alexander (Blend4Web Team)

Diff Detail

Event Timeline

Alexander Romanov (a.romanov) updated this revision to Diff 6973.Jun 28 2016, 1:49 PM

Alexander Romanov (a.romanov) retitled this revision from to BI Viewport(GLSL): support for envmap in Texture node.

Alexander Romanov (a.romanov) updated this object.

Alexander Romanov (a.romanov) updated this object.Jun 28 2016, 1:53 PM

Alexander Romanov (a.romanov) added reviewers: Campbell Barton (campbellbarton), Brecht Van Lommel (brecht).

Alexander Romanov (a.romanov) added subscribers: Yuri Kovelenov (yurikovelenov), Alexander Kovelenov (AlexKowel), Evgeny_Rodygin, Konstantin Khomyakov (homyachetser).

Seems generally fine, if you fix these two things you can commit it I think.

source/blender/nodes/shader/nodes/node_shader_texture.c
127	Code style is `if () {`.
135–136	This should be done before `direction_transform_m4v3`?

This revision now requires changes to proceed.Jul 2 2016, 8:49 PM

final corrections

In D2074#47880, @Brecht Van Lommel (brecht) wrote:

Seems generally fine, if you fix these two things you can commit it I think.

All things are fixed. I will commit the patch.

Closed by commit rBd4eb28ab7e48: BI Viewport(GLSL): support for envmap in Texture node (authored by Alexander Romanov (a.romanov)). · Explain WhyJul 4 2016, 10:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

shaders/

gpu_shader_material.glsl

7 lines

nodes/

shader/

nodes/

node_shader_texture.c

20 lines

Diff 6973

View Options

source/blender/gpu/shaders/gpu_shader_material.glsl