Differential D2090

Cycles: Add option to disable new Hair BVH
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Jul 7 2016, 6:06 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Thomas Dinges (dingto)

Commits

rC9e2d9b009f43: Add option to disable new Hair BVH
rBS6cd675af306e: Cycles: Add option to disable new Hair BVH
rB6cd675af306e: Cycles: Add option to disable new Hair BVH

Summary

While it's an extra option added to the interface which might not be
fully obvious for artists, it allows to save up to 20% of memory in
hairy scenes.

This is high enough memory saver in my opinion which might become
handy for some production files where it's more important to make
scene to fit into memory rather than trying to use more optimal BVH
structure but go into swap or crash.

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) updated this revision to Diff 7025.Jul 7 2016, 6:06 PM

Sergey Sharybin (sergey) retitled this revision from to Cycles: Add option to disable new Hair BVH.

Sergey Sharybin (sergey) added reviewers: Thomas Dinges (dingto), Brecht Van Lommel (brecht).

Sergey Sharybin (sergey) updated this object.

LGTM, don't mind the extra option in this case.

This revision is now accepted and ready to land.Jul 7 2016, 6:21 PM

Just to clarify some things after discussion with @Thomas Dinges (dingto) in irc:

20% memory save is measured against 2.77a release.
New hair BVH is only using some percent more RAM (memory increase caused by extra stuff in bvh_nodes is just a bit higher than save caused by tri_storage).

Seems reasonable to add this.

I guess the general solution here could be to have a "prefer performance" / "prefer low memory usage" option, that controls a bunch of different settings to reduce memory usage at the cost of performance. With just a single setting that would be a bit silly though, so this seems fine until we maybe unify multiple such settings in the future.

Closed by commit rB6cd675af306e: Cycles: Add option to disable new Hair BVH (authored by Sergey Sharybin (sergey)). · Explain WhyJul 15 2016, 4:42 PM

This revision was automatically updated to reflect the committed changes.