The SEQPROP_STARTFRAME option is redundant since all calls to sequencer_generic_props__internal() use it and some common code unconditionally assumes the "frame_start" property exists. To simplify the code, this property is made non-optional and references to the SEQPROP_STARTFRAME flag removed.
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
I'll check on this patch, Its quite reasonable for regular strips however for effects strips that lock to other strips it may be reasonable not to pass a frame.
Comment Actions
Even [some of] the effect strip code uses it, i.e.:
static int sequencer_add_effect_strip_exec(bContext *C, wmOperator *op)
{
Scene *scene = CTX_data_scene(C);
Editing *ed = BKE_sequencer_editing_get(scene, true);
Sequence *seq; /* generic strip vars */
Strip *strip;
struct SeqEffectHandle sh;
int start_frame, end_frame, channel, type; /* operator props */
Sequence *seq1, *seq2, *seq3;
const char *error_msg;
start_frame = RNA_int_get(op->ptr, "frame_start");
.
.
.