Page MenuHome

Rigify updates and fixes
ClosedPublic

Authored by Lucio Rossi (luciorossi) on Jul 18 2016, 8:44 PM.

Details

Summary

pitchipoy.super_face
The “super_face” sample rig and the “Pitchipoy Human (Meta Rig)” have some positional errors in the central bones. In effect all the heads/tails of the bones placed on the mirror line should have x=0 position and are instead created with slight different values. This will lead to some misalignments of the controls in the generated rig. After our fix the bones are now generated at correct position in both “super_face” sample rig and the “Pitchipoy Human (Meta Rig)”.

pitchipoy.super_palm
The “Pitchipoy Human (Meta Rig)” used the default “palm” rig type from original Rigify code when generating the Hand rig. Scaling non uniformly the hand control on the rig generated with this type will lead to crazy deformations on the finger bones. The problem is related to some “inherit scale” options on the parented bones. In order to leave untouched the original Rigify code we created a new rig type and named it “super_palm” using the pitchipoy naming convenction. We changed the bone parenting so that the hand can be scaled non uniformly without destroying its children bones. This new palm type is needed to append fingers and toes to the “paw” rig type.

Diff Detail

Event Timeline

Ivan Cappiello (icappiello) retitled this revision from to Rigify updates and fixes.
Ivan Cappiello (icappiello) updated this object.
Ivan Cappiello (icappiello) set the repository for this revision to rBA Blender Add-ons.

This rig was originally committed by @Nathan Vegdahl (cessen),
Correcting locations should be fine, but not sure of implications for adjusting inherit scale.

Mailed PitchiPoy developers, would be nice if they can review changes to their rig.

This rig was originally committed by @Nathan Vegdahl (cessen),
Correcting locations should be fine, but not sure of implications for adjusting inherit scale.

@Campbell Barton (campbellbarton) @Nathan Vegdahl (cessen) the inherit scale modification is necessary to prevent undesired results after non uniform scaling on the hand control. If you want to check it just generate the rig leaving inherit scale values active, then rotate the hand and scale it non uniformly (ex: S Y Y) and you will see the fingers controls and deform bones exploding in all directions. Anyway our modification is applied to a new rig type with a different name. The old one is still there and will not be affected by the modification.

Mailed PitchiPoy developers, would be nice if they can review changes to their rig.

@Campbell Barton (campbellbarton) It would be nice! i contacted some time ago Tamir Lousky via linkedin ad informed him about our work.

Campbell Barton (campbellbarton) edited edge metadata.

Tamir who worked on rigify replied but doesn't have time to review changes at this moment.
So accepting the patch since it seems quite reasonable.

This revision is now accepted and ready to land.Jul 19 2016, 3:47 PM
Campbell Barton (campbellbarton) requested changes to this revision.Jul 19 2016, 3:51 PM
Campbell Barton (campbellbarton) edited edge metadata.

On applying the patch I get the error:

error: rigify/rigs/pitchipoy/super_palm.py: does not exist
This revision now requires changes to proceed.Jul 19 2016, 3:51 PM
Ivan Cappiello (icappiello) edited edge metadata.
Ivan Cappiello (icappiello) removed rBA Blender Add-ons as the repository for this revision.

adding the missing super_palm.py file.

This revision is now accepted and ready to land.Jul 21 2016, 7:09 PM

Thanks for the update, committed:

  • rBf862db54403067248a3ca00edc5eec4935b3228b
  • rBc16bac5b9e1f3543ff35b5df5bff0f27b6c19ea0

@Lucio Rossi (luciorossi) & @Ivan Cappiello (icappiello) have been granted commit access to the add-ons repository to continue development on rigify.