Page MenuHome
Differential D2117

Experimental mempool use for ID datablocks
Needs ReviewPublic
Actions

Authored by Campbell Barton (campbellbarton) on Jul 21 2016, 6:28 PM.

Details

Reviewers
Bastien Montagne (mont29)
Julian Eisel (Severin)
Sergey Sharybin (sergey)
Summary

This uses memory pools for ID datablocks, reducing memory fragmentation and improves memory access speed for look-ups.

Uploading the patch for reference, actual gains aren't so much (~20 - 30% faster lookups & object duplication).

  • USE_ID_MEMPOOL define can be disabled to use normal memory allocation.
  • Local ID's (nodeTrees) don't use memory pools.
  • Needed to share memory pools between Main, since library linking moves ID's between Main's when linking, making local.

Overall, quite skeptical of this being worth the extra overhead and complication from supporting a different allocation method.

Applies to rBecd33bacf0992d67bbad8e2c70996639837503b1

Diff Detail

Repository
rB Blender
Branch
TEMP-ID_MEMPOOL
Build Status
Buildable 31
Build 31: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) updated this revision to Diff 7100.Jul 21 2016, 6:28 PM
Campbell Barton (campbellbarton) retitled this revision from to Experimental mempool use for ID datablocks.
Campbell Barton (campbellbarton) updated this object.
Campbell Barton (campbellbarton) updated this object.Jul 21 2016, 6:36 PM
Campbell Barton (campbellbarton) added reviewers: Bastien Montagne (mont29), Sergey Sharybin (sergey), Julian Eisel (Severin).
Campbell Barton (campbellbarton) updated this object.
Bastien Montagne (mont29) edited edge metadata.Jul 23 2016, 11:00 AM

Well… Am not a big fan of adding more complexity here either, especially if gains are not that great… Nice test though. :)

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
22 lines
intern/
257 lines
13 lines
4 lines
blenloader/
intern/
60 lines
editors/
render/
8 lines
space_node/
2 lines
makesdna/
3 lines
intern/
15 lines
windowmanager/
intern/
13 lines
4 lines

Diff 7100

View Options

source/blender/blenkernel/BKE_library.h

Loading...
View Options

source/blender/blenkernel/intern/library.c

Loading...
View Options

source/blender/blenkernel/intern/library_remap.c

Loading...
View Options

source/blender/blenkernel/intern/node.c

Loading...
View Options

source/blender/blenloader/intern/readfile.c

Loading...
View Options

source/blender/editors/render/render_preview.c

Loading...
View Options

source/blender/editors/space_node/node_group.c

Loading...
View Options

source/blender/makesdna/DNA_genfile.h

Loading...
View Options

source/blender/makesdna/intern/dna_genfile.c

Loading...
View Options

source/blender/windowmanager/intern/wm.c

Loading...
View Options

source/blender/windowmanager/intern/wm_init_exit.c

Loading...