As title says... Copying tracking data from movieclip was not the simplest thing,
so would rather get a quick review from our "tracking guy" before it goes to master. ;)
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Generally fine, just doblecheck you copied all the pointers.
| source/blender/blenkernel/intern/tracking.c | ||
|---|---|---|
| 199 | In own code prefer to have explicit NULL checks. | |
| 278 | Could be easier to simply tag dopesheet to be updated instead of copying it. | |
| 332 | Distortion can also be simply left out i think. Will be re-synchronized on demand later AFAIR. | |
Comment Actions
Thanks will update and commit! :)
| source/blender/blenkernel/intern/tracking.c | ||
|---|---|---|
| 199 | I don’t mind, but you might want to do the same in your tracking_xxx_free functions then. ;) | |