Allow NDOF view movement for modal select operators
ClosedPublic
Actions

Authored by Kai Mach (kai_mach) on Aug 22 2016, 7:08 AM.

Details

Reviewers

Commits

rBS56064b508b93: NDOF: allow view movement for modal border and circle select operators.
rB56064b508b93: NDOF: allow view movement for modal border and circle select operators.

Summary

Hello Folks,

as 3D-Mouse (NDOF) user I found it always somewhat annoying not been able to move the view while circle selecting some verts or so, having to deactivate circle select, move the view and activate it again.
So I added NDOF_MOTION event handling to circle and border select.

Reading comments in the code, I see it was thought about allowing view movement previously. So maybe the event handling here could be generalized by introducing a VIEW_CHANGE event, which can encapsulate other view changing events like the NUM-Keys or other fancy devices. But as this is my first travel into Blenders code, I did not go as far...

So it's my first patch - please be nice ;)

Diff Detail

Repository: rB Blender

Event Timeline

Kai Mach (kai_mach) updated this revision to Diff 7275.Aug 22 2016, 7:08 AM

Kai Mach (kai_mach) retitled this revision from to Allow NDOF view movement to modal select operators.

Kai Mach (kai_mach) updated this object.

Kai Mach (kai_mach) added a reviewer: Brecht Van Lommel (brecht).

Kai Mach (kai_mach) set the repository for this revision to rB Blender.

Kai Mach (kai_mach) added projects: User Interface, Good First Issue.

Kai Mach (kai_mach) retitled this revision from Allow NDOF view movement to modal select operators to Allow NDOF view movement for modal select operators.Aug 22 2016, 7:16 AM

Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Aug 23 2016, 1:17 AM

Technically speaking it's not entirely safe because you might get problems if such an NDOF event is configured to launch operators that do more than just view navigation. A more generic system could ensure that, but probably it's not an actual issue and this is ok for now.

We're in bugfixing only mode at the moment, so committing this will have to wait until after the 2.78 release.

This revision is now accepted and ready to land.Aug 24 2016, 2:55 AM

Committed now, thanks for the patch.

Closed by commit rB56064b508b93: NDOF: allow view movement for modal border and circle select operators. (authored by Kai Mach (kai_mach), committed by Brecht Van Lommel (brecht)). · Explain WhySep 10 2016, 11:48 PM

This revision was automatically updated to reflect the committed changes.

Hi. Could NDOF movement be also allowed while performing transforms either with the 3D manipulator widget or with G/R/S hotkeys?

Revision Contents
Changeset List

Path

Size

source/

blender/

windowmanager/

intern/

wm_operators.c

10 lines

Diff 7275

View Options

source/blender/windowmanager/intern/wm_operators.c

Allow NDOF view movement for modal select operatorsClosedPublicActions