[Windows] Add support for code signing the final binaries.
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Aug 30 2016, 4:28 AM.

Details

Reviewers

Sergey Sharybin (sergey)
Martijn Berger (juicyfruit)

Commits

rBS8fb9f2dbe9cb: [Windows] Add support for code signing the final binaries.
rB8fb9f2dbe9cb: [Windows] Add support for code signing the final binaries.

Summary

The option is controlled with the WITH_WINDOWS_CODESIGN option and needs:

Signtool must be found on the system, the standard windows sdk folders will be searched for it.
The path to the pfx file (WINDOWS_CODESIGN_PFX)
The password for the pfx , this can either be set by the WINDOWS_CODESIGN_PFX_PASSWORD variable but given that ends up in CMakeCache.txt (which might be undesirable) there is a backup option of setting the PFXPASSWORD environment variable on the system.

Diff Detail

Repository: rB Blender

Event Timeline

Ray Molenkamp (LazyDodo) updated this revision to Diff 7335.Aug 30 2016, 4:28 AM

Ray Molenkamp (LazyDodo) retitled this revision from to [Windows] Add support for code signing the final binaries. .

Ray Molenkamp (LazyDodo) updated this object.

Ray Molenkamp (LazyDodo) added reviewers: Sergey Sharybin (sergey), Martijn Berger (juicyfruit).

Ray Molenkamp (LazyDodo) set the repository for this revision to rB Blender.

Ray Molenkamp (LazyDodo) added projects: BF Blender, Platform: Windows.

The only comment I have is that we might in the future generalize WINDOWS_CODESIGN to CODESIGN and then figure out by platform what this intend implies.

Also for the release process we might want to sign the .msi also but I see no pressing reason to hack cmake into allowing for that now.

This revision is now accepted and ready to land.Aug 30 2016, 8:18 AM

Closed by commit rB8fb9f2dbe9cb: [Windows] Add support for code signing the final binaries. (authored by Ray Molenkamp (LazyDodo)). · Explain WhyAug 31 2016, 2:26 PM

This revision was automatically updated to reflect the committed changes.