Page MenuHome
Differential D2186

T47478 better UVs to icosphere
ClosedPublic
Actions

Authored by peter lu (pdlla) on Sep 1 2016, 6:33 PM.

Details

Reviewers
Bastien Montagne (mont29)
Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)
Maniphest Tasks
T47478: new default UV coordinates on some mesh primitives are poor/missing
Summary

I added better UVs for icosphere primitive. UVs are hardcoded and dependent on face/loop order.

This is my first contribution so there are likely issues I'm not aware of. I'm also sure I broke like every commit guideline. Please let me know :).

Diff Detail

Event Timeline

peter lu (pdlla) updated this revision to Diff 7351.Sep 1 2016, 6:33 PM
peter lu (pdlla) retitled this revision from to T47478 better UVs to icosphere.
peter lu (pdlla) updated this object.
Aaron Carlisle (Blendify) added reviewers: Sergey Sharybin (sergey), Bastien Montagne (mont29).Sep 2 2016, 6:11 PM
Aaron Carlisle (Blendify) added a task: T47478: new default UV coordinates on some mesh primitives are poor/missing.Sep 4 2016, 8:45 PM
peter lu (pdlla) mentioned this in D2202: T47478 better generated UVs for UV sphere .Sep 7 2016, 8:31 PM
peter lu (pdlla) mentioned this in T47478: new default UV coordinates on some mesh primitives are poor/missing.Sep 7 2016, 8:50 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 11 2016, 1:49 AM
Brecht Van Lommel (brecht) added a reviewer: Brecht Van Lommel (brecht).
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Only comment I have is a minor style consistency nitpick, to add a space after the commas in the icouvs table. Other than that it looks good to me, I like these UVs better than the previous ones.

This revision is now accepted and ready to land.Sep 11 2016, 1:49 AM
peter lu (pdlla) closed this revision.Sep 12 2016, 6:31 PM
This comment was removed by peter lu (pdlla).
peter lu (pdlla) added a comment.Sep 12 2016, 6:33 PM

I'm closing this and D2202 to submit a new patch with updated UVs for uv sphere, icosphere and Suzanne.

peter lu (pdlla) mentioned this in D2224: T47488 T47478 Updated UVs for Suzanne, UV sphere and Icosphere.Sep 12 2016, 7:17 PM

Revision Contents
Changeset List

PathSize
source/
blender/
bmesh/
operators/
74 lines

Diff 7351

View Options

source/blender/bmesh/operators/bmo_primitive.c

Loading...