Page MenuHome
Differential D2188

Fix 'warning: double precision constant requires cl_khr_fp64, casting to single precision' in Cycles
AbandonedPublic
Actions

Authored by Edward O'Callaghan (funfunctor) on Sep 2 2016, 2:13 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Martijn Berger (juicyfruit)
Summary

Fix OpenCL float/double conversion usage.

https://www.khronos.org/registry/cl/sdk/1.0/docs/man/xhtml/tan.html
https://www.khronos.org/registry/cl/sdk/1.0/docs/man/xhtml/cl_khr_fp64.html

Diff Detail

Event Timeline

Edward O'Callaghan (funfunctor) updated this revision to Diff 7354.Sep 2 2016, 2:13 PM
Edward O'Callaghan (funfunctor) retitled this revision from to Fix 'warning: double precision constant requires cl_khr_fp64, casting to single precision' in Cycles.
Edward O'Callaghan (funfunctor) updated this object.
Edward O'Callaghan (funfunctor) added a reviewer: Martijn Berger (juicyfruit).
Brecht Van Lommel (brecht) requested changes to this revision.EditedSep 2 2016, 9:02 PM
Brecht Van Lommel (brecht) added a reviewer: Brecht Van Lommel (brecht).
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

We don't intentionally use doubles in the kernel. Rather than enabling this extension, we probably just need to change a few constants or functions to use the f postfix.

This revision now requires changes to proceed.Sep 2 2016, 9:02 PM
Edward O'Callaghan (funfunctor) added a comment.Sep 3 2016, 3:35 AM
In D2188#51034, @Brecht Van Lommel (brecht) wrote:

We don't intentionally use doubles in the kernel. Rather than enabling this extension, we probably just need to change a few constants or functions to use the f postfix.

Can I leave you with that? My concern is the opensource radeon drivers so (mesa/clover, llvm & kernel).

Edward O'Callaghan (funfunctor) added a comment.Sep 3 2016, 3:37 AM

D2171 is also coupled with that work.

Brecht Van Lommel (brecht) abandoned this revision.Sep 4 2016, 1:49 PM

Ok, I've fixed a couple of those cases in rBe76e8fcdcc53.

If there's more please provide a build log with the warnings.

Edward O'Callaghan (funfunctor) added a comment.Sep 5 2016, 2:08 AM
In D2188#51102, @Brecht Van Lommel (brecht) wrote:

Ok, I've fixed a couple of those cases in rBe76e8fcdcc53.

Thanks!

If there's more please provide a build log with the warnings.

Yea no worries.

Revision Contents
Changeset List

PathSize
intern/
cycles/
kernel/
2 lines

Diff 7354

View Options

intern/cycles/kernel/kernel_types.h

Loading...