Page MenuHome

T47488 T47478 Updated UVs for Suzanne, UV sphere and Icosphere
ClosedPublic

Authored by peter lu (pdlla) on Sep 12 2016, 7:17 PM.

Diff Detail

Repository
rB Blender

Event Timeline

peter lu (pdlla) retitled this revision from to T47488 T47478 Updated UVs for Suzanne, UV sphere and Icosphere.
peter lu (pdlla) updated this object.
Brecht Van Lommel (brecht) requested changes to this revision.Sep 18 2016, 12:54 AM
Brecht Van Lommel (brecht) edited edge metadata.

Looks generally fine, but some comments.

source/blender/bmesh/operators/bmo_primitive.c
1045

Add space here and in other places: ) {

1101–1102

Use if (f->len == 3) {.

1116

Use len_v3(l->v->co);.

1147

Unused variable.

1255

Line wrap to maybe 80 chars for this comment. The code doesn't follow a strict convention here but 140 is a bit too long.

source/blender/editors/uvedit/uvedit_unwrap_ops.c
1184–1200 ↗(On Diff #7422)

This code should not be part of the patch.

This revision now requires changes to proceed.Sep 18 2016, 12:54 AM
peter lu (pdlla) edited edge metadata.
peter lu (pdlla) marked 6 inline comments as done.

Changes to better fit blender code conventions. (Fixed all code revision issues)

This revision was automatically updated to reflect the committed changes.

Committed with some minor fixes for style and tabs/spaces. Thanks for the patch!