Page MenuHome
Differential D2228

possible fix for T49343
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Sep 14 2016, 3:04 PM.

Details

Reviewers
Bastien Montagne (mont29)
Brecht Van Lommel (brecht)
Commits
rBSf64aa4e0afc7: Fix T49343: ImageFormatSettings were not setting their rna struct path correctly
rBf64aa4e0afc7: Fix T49343: ImageFormatSettings were not setting their rna struct path correctly
Summary

ImageFormatSettings were not setting their rna struct path

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) updated this revision to Diff 7433.Sep 14 2016, 3:04 PM
Philipp Oeser (lichtwerk) retitled this revision from to possible fix for T49343.
Philipp Oeser (lichtwerk) updated this object.
Philipp Oeser (lichtwerk) set the repository for this revision to rB Blender.
Philipp Oeser (lichtwerk) mentioned this in T49343: Python render setting commands are incorrect in the Info view.
Aaron Carlisle (Blendify) added a reviewer: Bastien Montagne (mont29).Sep 14 2016, 3:35 PM
Philipp Oeser (lichtwerk) added a comment.EditedSep 14 2016, 3:43 PM

note: bake uses this too (more others even?) So might have to consider a path like scene.render.bake.image_settings as well...

Bastien Montagne (mont29) requested changes to this revision.Sep 14 2016, 7:47 PM
Bastien Montagne (mont29) edited edge metadata.

Yeah, ImageFormatSettings can come from some compo nodes (i.e. based on NodeTree ID), and from Scene.render.image_settings and Scene.render.bake.image_settings (at least, those are the usecases I found searching a bit in RNA code). So you'll need a smarter rna_ImageFormatSettings_path function using ptr parameter to find correct path in every case…

This revision now requires changes to proceed.Sep 14 2016, 7:47 PM
Philipp Oeser (lichtwerk) updated this revision to Diff 7445.Sep 15 2016, 12:46 PM
Philipp Oeser (lichtwerk) edited edge metadata.
Philipp Oeser (lichtwerk) removed rB Blender as the repository for this revision.

covered cases in scene: bake, render
covered cases in nodetree: CMP_NODE_OUTPUT_FILE and also the individual fileslots of that node
should be all cases now (at least I couldnt find more)

Bastien Montagne (mont29) accepted this revision.Sep 15 2016, 1:41 PM
Bastien Montagne (mont29) edited edge metadata.
Bastien Montagne (mont29) added subscribers: Sergey Sharybin (sergey), Brecht Van Lommel (brecht).

Besides picky comment below patch now looks good to me, maybe @Sergey Sharybin (sergey) or @Brecht Van Lommel (brecht) want to have a look at it too?

source/blender/makesrna/intern/rna_scene.c
968

Those braces are not needed here...

This revision is now accepted and ready to land.Sep 15 2016, 1:41 PM
Brecht Van Lommel (brecht) accepted this revision.Sep 18 2016, 2:23 AM
Brecht Van Lommel (brecht) added a reviewer: Brecht Van Lommel (brecht).

Would be nice if we had a better system that didn't require so much code for this, but yes, patch seems fine.

Philipp Oeser (lichtwerk) updated this revision to Diff 7468.Sep 19 2016, 6:10 PM
Philipp Oeser (lichtwerk) edited edge metadata.
Philipp Oeser (lichtwerk) set the repository for this revision to rB Blender.

removed braces

Closed by commit rBf64aa4e0afc7: Fix T49343: ImageFormatSettings were not setting their rna struct path correctly (authored by Philipp Oeser (lichtwerk), committed by Bastien Montagne (mont29)). · Explain WhySep 20 2016, 12:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
makesrna/
intern/
49 lines

Diff 7468

View Options

source/blender/makesrna/intern/rna_scene.c

Loading...