Adopt referenced scene in the context when evaluating sequences within a Scene Strip.
ClosedPublic
Actions

Authored by Matt (HyperSphere) on Sep 22 2016, 1:45 PM.

Details

Reviewers

Bastien Montagne (mont29)
Sergey Sharybin (sergey)

Summary

This change makes it so that when the sequences within a Scene strip are evaluated, they use the Scene that they come from as the context as opposed the Scene that the Scene strip is in. This is necessary, for example, in the case of the MulticamSelector where it needs to reference strips in the original Scene as opposed to the Scene where the Scene strip is located.

Diff Detail

Event Timeline

Matt (HyperSphere) updated this revision to Diff 7487.Sep 22 2016, 1:45 PM

Matt (HyperSphere) retitled this revision from to Adopt referenced scene in the context when evaluating sequences within a Scene Strip..

Matt (HyperSphere) updated this object.

Matt (HyperSphere) set the repository for this revision to rB Blender.

Matt (HyperSphere) added a project: Video Sequencer.

Haha whoops! Just realized I used lowerCamelCase. showing my Java roots :P

lowerCamelCase -> lower_underscore

updated diff to show the original code

Matt (HyperSphere) set the repository for this revision to rB Blender.Sep 22 2016, 1:58 PM

This seems to make sense to me. @Bastien Montagne (mont29), am i missing some corner-case which will fail here?

No, lgtm and seems to make sense indeed… and can’t think of any bad corner case so far.

This revision is now accepted and ready to land.Sep 27 2016, 5:31 PM

@Matt (HyperSphere) doesn't have commit rights so somebody else needs to commit ;)

Hi all,

Thanks for the review! One question I had was about unit testing. I've spent a decent bit of time trying to add a simple unit test to the gtests directory based on the setup in the included blend file but I'm running into issues with linker errors. I saw that this would be the first unit test for something in blenkernel so I was wondering if there was some reason that I shouldn't add a unit test there? Should a test for this live within the python tests? If this isn't against protocol, I'll keep on chipping away.

To that end, my plan was to add a test that calls BKE_sequencer_give_ibuf and asserts something about the ibuf returned at a particular frame number. Here are a couple of questions that have occurred to me:

Is there another layer I should test this at?
I see that there are a couple flavors of BKE_sequencer_give_ibuf*. Is there one in particular I should test?
I'm getting a tremendous number of linker errors when I try to build my test. I was hoping not to have to include the world just to build this test. Any ways around this?

Here is first go at the test (I'm not making any assertions yet because I'm not sure what I should assert since I haven't been able to run this yet):
https://developer.blender.org/P405

Any comments about my approach, this idea or this code would be greatly appreciated!

Also, in terms of committing the fix, is there something you all need from my side?

Thanks,

Matt

Sergey Sharybin (sergey) mentioned this in T49424: VSE Scene Strip (in "Use Sequence" mode) Incompatible with certain Effect Strips.Sep 29 2016, 3:01 PM

This has been committed in rB57a2015f5674

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

sequencer.c

7 lines

Diff 7489

View Options

source/blender/blenkernel/intern/sequencer.c

Adopt referenced scene in the context when evaluating sequences within a Scene Strip.ClosedPublicActions