Page MenuHome
Differential D2271

draw region emboss with new immediate mode
ClosedPublic
Actions

Authored by Anthony Edlin (krash) on Oct 4 2016, 10:31 AM.

Details

Reviewers
Mike Erwin (merwin)
Commits
rBS2a76da9ec24c: draw region emboss with new immediate mode
rB2a76da9ec24c: draw region emboss with new immediate mode
Summary

Simple convert of drawing emboss lines to new immediate mode.

Part of T49043

Diff Detail

Event Timeline

Anthony Edlin (krash) updated this revision to Diff 7545.Oct 4 2016, 10:31 AM
Anthony Edlin (krash) retitled this revision from to draw region emboss with new immediate mode.
Anthony Edlin (krash) updated this object.
Anthony Edlin (krash) added a reviewer: Mike Erwin (merwin).
Anthony Edlin (krash) set the repository for this revision to rB Blender.
Anthony Edlin (krash) added a project: BF Blender: 2.8.
Mike Erwin (merwin) accepted this revision.Oct 4 2016, 1:07 PM
Mike Erwin (merwin) edited edge metadata.

Looks good! Challenge: get it down from 8 vertices to 5 with a GL_LINE_STRIP.

(could get it down to 4 with GL_LINE_LOOP but Vulkan doesn't have line loops)

This revision is now accepted and ready to land.Oct 4 2016, 1:07 PM
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Oct 4 2016, 1:34 PM

Out of curiosity, did you use arcanist to send the patch? I can't apply the patch directly here. As for GL_LINE_STRIP I don't think you can do it with 5 vertices, given that the color change for half the lines.

Mike Erwin (merwin) added a comment.Oct 4 2016, 2:53 PM
In D2271#52606, @Dalai Felinto (dfelinto) wrote:

As for GL_LINE_STRIP I don't think you can do it with 5 vertices, given that the color change for half the lines.

You totally can since GPU_SHADER_2D_FLAT_COLOR uses the color of each line segment's provoking vertex.

Anthony Edlin (krash) updated this revision to Diff 7557.Oct 6 2016, 9:20 PM
Anthony Edlin (krash) edited edge metadata.
Anthony Edlin (krash) removed rB Blender as the repository for this revision.

New diff with only 5 verts as suggested.

I noticed while fooling with this that it doesn't work in double pixel mode for retina like displays on linux, but it didn't work before either.

I didn't use Arc, just uploaded a diff file.

Mike Erwin (merwin) added a comment.Oct 6 2016, 10:08 PM

Perfect! @Anthony Edlin (krash) can you commit this, or should one of us do it & give you credit?

Anthony Edlin (krash) set the repository for this revision to rB Blender.Oct 8 2016, 5:17 AM
Anthony Edlin (krash) added a comment.EditedOct 8 2016, 5:19 AM

I can't commit anything as far as I know.

Mike Erwin (merwin) closed this revision.Oct 8 2016, 5:49 AM

Done! Landed in blender2.8

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
screen/
29 lines

Diff 7557

View Options

source/blender/editors/screen/area.c

Loading...