Yes!

Since color is set once for the whole roundbox, we can use GPU_SHADER_2D_UNIFORM_COLOR!

Color values still need to be passed into the function like you did. Just call immUniformColor4ubv right after binding the shader program.

Suggestion:

const unsigned char color[4] = { ... };
UI_draw_roundbox_gl_mode( ... , color);

Leave UI_ThemeColor functions alone for now. Lots of drawing code uses these!

Use existing UI_GetThemeColor functions to fetch color values (you might need to add one or two missing functions).

Function owns the returned memory, so lifetime is ok... but the values are only good for a very short (undetermined) time. Calling again in the same thread or a different thread trashes the data.

I don't think we don't need this function.

No part of blender use the return of this function, it can still be a problem??

As you say it's used a lot of time, that why i make it, it's and will be a lot easier to make all the modification with this.
Do you have any plan to do something similar?

But you know it better than me for sure, I hope.... :-))))))

Not sure why 72? I only count 32 vertices.

I'd prefer to get rid of the UI_ThemeColorXXX functions and only keep the UI_GetThemeColorXXX ones. I guess after 3.2 core profile transition they'll be useless anyway since it doesn't use color states (right?).

Hmm, good points... All this makes me start thinking about a better API for using theme colors! But that's not really part of the immediate mode task.

UI_ThemeColor updates current OpenGL state to use a theme color. With your change it does that *and* returns a convenient pointer.

I still prefer the UI_GetThemeColor functions for this, since you are just getting a color. Yes it's less convenient to call. But it's not that bad.

euh, not sure, we declare the vertex count or coordinate count??
36 vertex but 72 coordinate

it's was me idee too, when 3.2 core will be activated we only delete glColor4ubv(cp); for eg. no?

@Julian Eisel (Severin) is trying to crash us! I count 36 too.

they'll be useless anyway since it doesn't use color states

Right, those functions will be obsolete. After that maybe we can redo the theme color API.

I try it and you're right... I've made the change.
thanks

vertex count or coordinate count?

Yep it's vertex count. Doesn't matter if coordinates are 2D or 3D. Also doesn't matter how many attributes each vertex has. I'll remember to explain this better in the docs.

OK, I think I see what you mean (I hope ;-)))) )

unsigned char color[4];
UI_GetThemeColor4ubv(TH_PREVIEW_BACK, color)

UI_draw_roundbox_corner_set(UI_CNR_ALL);
UI_draw_roundbox_gl_mode(GL_POLYGON, rect.xmin - 1, rect.ymin - 1, rect.xmax + 1, rect.ymax + 1, 3.0f, color);

it would be good, that's what you mean/want??

if yes I have to make UI_GetThemeColorShade4ubv too for eg??

Yes to all of that :)

I disagree here. Why should a roundbox drawing function have two or more interfaces? I think it should just take byte[4] colors (like now) or just float[4] colors and callers have to deal with it.

Looks like float colors are used more often so can we use that?

UI_GetThemeColorShade4fv already exists. Keep the new UI_GetThemeColorShade4ubv because it is useful.

I'll add immUniformColor4fv in a minute, so "git stash" then "git pull --rebase" then "git stash pop".

Sorry for the extra work @Krantz Geoffroy (kgeogeo) -- we're almost there!