Page MenuHome
Differential D2276

console_draw.c opengl update
ClosedPublic
Actions

Authored by Martijn Berger (juicyfruit) on Oct 6 2016, 7:21 PM.

Details

Reviewers
Fable Fox (fablefox)
Mike Erwin (merwin)
Commits
rBSb757e8298abd: Convert console_draw.c to Gawain
rBb757e8298abd: Convert console_draw.c to Gawain
Summary

include header and replaced glColor3ubv

Diff Detail

Event Timeline

Fable Fox (fablefox) updated this revision to Diff 7555.Oct 6 2016, 7:21 PM
Fable Fox (fablefox) retitled this revision from to console_draw.c opengl update.
Fable Fox (fablefox) updated this object.
Fable Fox (fablefox) added a reviewer: Mike Erwin (merwin).
Fable Fox (fablefox) set the repository for this revision to rB Blender.
Fable Fox (fablefox) added projects: BF Blender: 2.8, GPU / Viewport.
Dalai Felinto (dfelinto) added a subscriber: Dalai Felinto (dfelinto).Oct 6 2016, 8:11 PM

You will need to replace glRecti which is where the "fun" begins (you will need to bind a program, pass a vertex format, ...).

Also @Fable Fox (fablefox) please edit the wiki to claim this file for you: https://wiki.blender.org/index.php/Dev:2.8/Source/OpenGL/Immediate_Mode_Replacement_Tasks

Fable Fox (fablefox) added a comment.Nov 3 2016, 3:45 PM

I have to leave this OpenGL replacement job as-is due to work and also I'm taking OCA 12c exam end of this month (also related to day work). Glad to see it progress well on the task page.

Martijn Berger (juicyfruit) commandeered this revision.Nov 16 2016, 3:04 PM
Martijn Berger (juicyfruit) updated this revision to Diff 7816.
Martijn Berger (juicyfruit) added a reviewer: Fable Fox (fablefox).
Martijn Berger (juicyfruit) removed rB Blender as the repository for this revision.

Think we could search for way to reuse the same program more. But for now this seems to be a replacement that works

Mike Erwin (merwin) added inline comments.Nov 16 2016, 5:57 PM
source/blender/editors/space_console/console_draw.c
176

Could use the UNIFORM_COLOR shader here.

Related changes:

  • remove color attribute from format above
  • single call to immThemeColor(TH_CONSOLE_CURSOR);
Martijn Berger (juicyfruit) updated this revision to Diff 7822.Nov 16 2016, 10:46 PM
Mike Erwin (merwin) accepted this revision.Nov 16 2016, 10:48 PM
Mike Erwin (merwin) edited edge metadata.
This revision is now accepted and ready to land.Nov 16 2016, 10:48 PM
Martijn Berger (juicyfruit) closed this revision.Nov 16 2016, 11:00 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_console/
20 lines

Diff 7816

View Options

source/blender/editors/space_console/console_draw.c

Loading...