Differential D2280

Add missing UV tools in the UV/Image Editor Window > Tools tab
ClosedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Oct 7 2016, 7:59 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)
Julian Eisel (Severin)
Brendon Murphy (meta-androcto)

Group Reviewers

Maniphest Tasks

T40296: Add missing UV tools in the UV/Image Editor Window > Tools tab

Summary

Original patch by @xrg (xrg) updated to master by @Aaron Carlisle (Blendify)

Image of patch:

To test either apply the patch or open the file below in blender's text editor and hit run script.

space_image.py43 KBDownload

Diff Detail

Event Timeline

This patch needs to be updated to master

Aaron Carlisle (Blendify) added a task: T40296: Add missing UV tools in the UV/Image Editor Window > Tools tab.Oct 7 2016, 8:01 PM

Paweł Łyczkowski (plyczkowski) added a subscriber: Paweł Łyczkowski (plyczkowski).Oct 7 2016, 8:14 PM

Update to master

Aaron Carlisle (Blendify) added inline comments.Oct 7 2016, 10:26 PM

release/scripts/startup/bl_ui/space_image.py
798	Unsure if this is needed or not

This is ready to review

Remove unused variable declaration.

@Aaron Carlisle (Blendify) put some reviewers to get it reviewed, looks good.

Aaron Carlisle (Blendify) updated this object.Jan 3 2017, 7:36 PM

Aaron Carlisle (Blendify) added reviewers: Julian Eisel (Severin), Brendon Murphy (meta-androcto).

Aaron Carlisle (Blendify) set the repository for this revision to rB Blender.

Aaron Carlisle (Blendify) added a subscriber: Mike Pan (mpan3).

Update to master, cleanup whitespace

Whitespace again

Aaron Carlisle (Blendify) added a reviewer: Campbell Barton (campbellbarton).Mar 31 2017, 11:10 PM

I would really like to see this in 2.79

The panels weren't showing up for me when applying the patch, probably due to recent changes from rB9bdda427e6ff. They needed to be added to the classes list at the bottom of the file.

Layout looks fine to me.

release/scripts/startup/bl_ui/space_image.py
747–761	I would leave ":" out of the labels here, as far as I can tell convention is not to use it in such cases.
750–751	Use math.pi/2 instead of hardcoded value.

From review:

Correct op labels.
Use pi instead of hardcoded value.
Update to master (includes un-register fixes)

Aaron Carlisle (Blendify) marked 2 inline comments as done.Apr 10 2017, 2:38 AM

Brecht Van Lommel (brecht) accepted this revision.Apr 10 2017, 3:32 AM

This revision is now accepted and ready to land.Apr 10 2017, 3:32 AM

Cleanup: White space

Committed in rB8b0fbb909b158916a8161b4e8bca848fdbe3879d

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

93 lines

Diff 8593

release/scripts/startup/bl_ui/space_image.py

Loading...