Add kerning support for 3DText
Needs ReviewPublic
Actions

Authored by Sebastian Witt (witt) on Oct 8 2016, 1:53 PM.

Details

Reviewers

Bastien Montagne (mont29)
Sergey Sharybin (sergey)

Summary

This is my second approach on adding kerning support for the 3DText objects.
For a reference here is my first approach: https://developer.blender.org/T47725

Kerning is added by, keeping the Freetype2 Lib loaded and the data for the font face within the vFontData object.
So FT_Get_Kerning can be accessed while the vFontData exists.

I hope the code fits to all the standards!
Any kind of feedback is appreciated,

Sebastian Witt

Diff Detail

Repository: rB Blender

Event Timeline

Sebastian Witt (witt) updated this revision to Diff 7580.Oct 8 2016, 1:53 PM

Sebastian Witt (witt) retitled this revision from to Add kerning support for 3DText.

Sebastian Witt (witt) updated this object.

Sebastian Witt (witt) added a reviewer: Bastien Montagne (mont29).

Sebastian Witt (witt) set the repository for this revision to rB Blender.

Sebastian Witt (witt) added a project: BF Blender.

Patch is mostly OK I think, besides points noted below, and please respect our code style.

Wouldn’t mind @Sergey Sharybin (sergey)'s advice here though, he knows our 3DText code much better than I do…

source/blender/blenkernel/intern/font.c
271–275	Why remove this? it may lead to pf leaking? would rather add check on vfont->data->assoc_data (or maybe just remove the check on vfont->packedfile ?).
source/blender/blenlib/intern/freetypefont.c
504	Error, mismatch in signature with declaration of this func...

I tried to address all the problems with the old revision.
Mainly possible packedfile data leaks and "BLI_vfontdata_freeft2" function definition.

If I can improve the code style in any way, I am happy and open for every critique/tips!
Kind regards
Sebastian Witt

Sebastian Witt (witt) marked 2 inline comments as done.Nov 4 2016, 4:38 PM

Sebastian Witt (witt) added inline comments.

source/blender/blenkernel/intern/font.c
271–275	You are right, I removed that due to the pf still containing the fontdata and which gets deleted if freed at this point. I am handling the pf memory later on when the vfont is removed. In case vfont is Null it still needs to be freed. Like you've said removing only vfont->packedfile should do the trick!

Jacques Lucke (JacquesLucke) mentioned this in T69805: Text objects ignore font kerning data.Sep 19 2019, 4:45 PM

Sam Van Hulle (sam_vh) awarded a token.Sep 22 2019, 11:24 PM

Sam Van Hulle (sam_vh) added a subscriber: Sam Van Hulle (sam_vh).

Any news on this?

Alfonso Guerra (Huperniketes) added a subscriber: Alfonso Guerra (Huperniketes).Apr 21 2020, 1:37 AM

Alfonso Guerra (Huperniketes) awarded a token.Apr 21 2020, 1:52 AM

@Bastien Montagne (mont29), late reply. I can't think of anything wrong here. Think it's a useful feature.

source/blender/blenlib/BLI_vfontdata.h
47	Could it be called something less generic?

Anton Raves (Memento) added a subscriber: Anton Raves (Memento).May 31 2020, 7:23 AM

Anton Raves (Memento) awarded a token.Sep 20 2020, 8:32 AM

Evan Wilson (EAW) awarded a token.Sep 21 2020, 10:47 PM

Evan Wilson (EAW) added a subscriber: Evan Wilson (EAW).

ogierm added a subscriber: ogierm.Sep 21 2020, 11:37 PM

Matyáš Sojka (sojkamat) added a subscriber: Matyáš Sojka (sojkamat).Jan 29 2021, 2:08 PM

Hey, I am working on a bachelor thesis - using Blender plugin to create a 3D presentation. I tried to use your code to fix the kerning, beceuase it is obviously important for a presentation, but I don't seem be able to make it work...
I'm using Blender 2.93.0, when I tried to compile it after the changes, in the file font.c the compiler couldnt find the function freePackedFile(vfont->data->assoc_data), so I used BKE_packedfile_free(vfont->data->assoc_data) and the compilation went fine, but the kerning was still not supported after runnig the compiled version.
Do you have any tips on how to make it work? Or do you have any info, if automatic kerning support will be added to Blender any time soon? Or perhaps do you have a binary, where the kerning is supported?
Thanks for any tips or comments :)

Andreas Böhm (ndrsbhm) added a subscriber: Andreas Böhm (ndrsbhm).Apr 9 2021, 3:09 PM

Pablo Vazquez (pablovazquez) awarded a token.May 9 2022, 8:57 PM

Stian Andreassen (stianandreassen) awarded a token.Sep 14 2022, 2:04 AM

I'm a user and not a developer. This has been bugging me for years.
I don't believe anyone who is serious about typography could be without this feature.

Would this also work with the "String to Curves" geometry node?