Page MenuHome

blender 2.8: OpenGL: node_circle_draw use now immediate mode
ClosedPublic

Authored by Krantz Geoffroy (kgeogeo) on Oct 10 2016, 12:06 PM.

Diff Detail

Event Timeline

Krantz Geoffroy (kgeogeo) retitled this revision from to blender 2.8: OpenGL: node_circle_patch use now immediate mode.
Krantz Geoffroy (kgeogeo) updated this object.
Krantz Geoffroy (kgeogeo) retitled this revision from blender 2.8: OpenGL: node_circle_patch use now immediate mode to blender 2.8: OpenGL: node_circle_draw use now immediate mode.

I like this! Before accepting let's see if VertexFormat setup and program bind can be pulled into the calling function. If so that would be more efficient.

source/blender/editors/space_node/node_draw.c
637

only need 3 elements

945

spaces around *

953

same as above

set up VertexFormat
bind shader program

/* socket inputs, buttons */
for (sock = node->inputs.first; sock; sock = sock->next) {
	if (nodeSocketIsHidden(sock))
		continue;

	node_socket_circle_draw(C, ntree, node, sock, NODE_SOCKSIZE, sock->flag & SELECT);
}
	
/* socket outputs */
for (sock = node->outputs.first; sock; sock = sock->next) {
	if (nodeSocketIsHidden(sock))
		continue;

	node_socket_circle_draw(C, ntree, node, sock, NODE_SOCKSIZE, sock->flag & SELECT);
}

unbind shader program

You'll have to pass pos into this function.

Krantz Geoffroy (kgeogeo) edited edge metadata.

change done I think.

Sorry git was not up to date :-(((

source/blender/editors/space_node/node_draw.c
927

Move comment down to its loop.

Vertex format & shader program apply to both loops, not just this one.

1087

Move comment down to its loop. Might as well make it say "socket inputs" too.

source/blender/editors/space_node/node_draw.c
627
2.0f * size

Guess this is a radius --> diameter conversion

Krantz Geoffroy (kgeogeo) updated this revision to Diff 7594.
Krantz Geoffroy (kgeogeo) marked 3 inline comments as done.

change for diameter

Mike Erwin (merwin) edited edge metadata.
This revision is now accepted and ready to land.Oct 15 2016, 6:14 AM

landed in blender2.8