Page MenuHome
Differential D22

Code cleanup: Move some uiBut->flag to uiBut->drawflag, make those flags anonymous enums.
ClosedPublic
Actions

Authored by Bastien Montagne (mont29) on Nov 20 2013, 9:22 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Summary

Make some room in but->flag (I did not add another flag, we already have drawflag, which was nearly not used up till now).

Note: I’m not sure whether REDALERT (and perhaps even DISABLED?) should not go to but->drawflag as well...

Related to D8

Diff Detail

Branch
work_1

Event Timeline

Brecht Van Lommel (brecht) accepted this revision.Nov 20 2013, 11:27 PM

Good stuff, go ahead and commit.

I verified here as well that the drawflag enum values are assigned to and read from the right variables and it all seems to check out.

Bastien Montagne (mont29) closed this revision.Nov 21 2013, 2:46 PM

Committed as rB254aa8f3a0fbffcbcb886cfaa81b630ae3e9bb78

Note I could not use arc land here (those ugly git submodules mess), so I mimicked it (git checkout master, git pull --rebase, git checkout work_1, git rebase master, git checkout master, git merge --squash --ff-only work_1, git commit)… :/

Dalai Felinto (dfelinto) mentioned this in D11568: Phabricator: Extend CONDUIT API to support xaction transactions.Jun 10 2021, 2:46 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
include/
82 lines
interface/
30 lines
2 lines
16 lines
16 lines
12 lines
7 lines
30 lines
space_buttons/
4 lines
space_file/
2 lines
space_node/
11 lines
space_view3d/
4 lines

Diff 44

View Options

source/blender/editors/include/UI_interface.h

Loading...
View Options

source/blender/editors/interface/interface.c

Loading...
View Options

source/blender/editors/interface/interface_handlers.c

Loading...
View Options

source/blender/editors/interface/interface_intern.h

Loading...
View Options

source/blender/editors/interface/interface_layout.c

Loading...
View Options

source/blender/editors/interface/interface_regions.c

Loading...
View Options

source/blender/editors/interface/interface_templates.c

Loading...
View Options

source/blender/editors/interface/interface_widgets.c

Loading...
View Options

source/blender/editors/space_buttons/buttons_texture.c

Loading...
View Options

source/blender/editors/space_file/file_panels.c

Loading...
View Options

source/blender/editors/space_node/node_templates.c

Loading...
View Options

source/blender/editors/space_view3d/view3d_buttons.c

Loading...