Page MenuHome
Differential D2317

Mantaflow: Use Path objects instead of os.path.join()
ClosedPublic
Actions

Authored by Jeffrey Hoover (italic_) on Oct 24 2016, 1:15 AM.

Details

Reviewers
Sebastián Barschkis (sebbas)
Commits
rB657259fbaac0: Mantaflow: Use Path objects instead of os.path.join()
Summary

File paths are passed into these functions, so convert passed path to pathlib.Path object to avoid internal/external conflicts. This should be easier to maintain and visually cleaner.

Diff Detail

Repository
rB Blender
Branch
fluid-mantaflow
Build Status
Buildable 250
Build 250: arc lint + arc unit

Event Timeline

Jeffrey Hoover (italic_) updated this revision to Diff 7689.Oct 24 2016, 1:15 AM
Jeffrey Hoover (italic_) retitled this revision from to Mantaflow: Use Path objects instead of os.path.join().
Jeffrey Hoover (italic_) updated this object.
Jeffrey Hoover (italic_) added a reviewer: Sebastián Barschkis (sebbas).
Sebastián Barschkis (sebbas) accepted this revision.Oct 24 2016, 11:10 AM
Sebastián Barschkis (sebbas) edited edge metadata.

Looking good, this makes it much more readable!

This revision is now accepted and ready to land.Oct 24 2016, 11:10 AM
Sebastián Barschkis (sebbas) closed this revision.Oct 27 2016, 5:16 PM

Just some new line characters were missing. Committed 657259fbaac0.

Sebastián Barschkis (sebbas) mentioned this in rB88537b758edd: reverting to old IO functions. changes from D2317 produce posixpath….Nov 7 2016, 12:57 AM

Revision Contents
Changeset List

PathSize
intern/
mantaflow/
intern/
strings/
84 lines
4 lines
90 lines

Diff 7689

View Options

intern/mantaflow/intern/strings/liquid_script.h

Loading...
View Options

intern/mantaflow/intern/strings/shared_script.h

Loading...
View Options

intern/mantaflow/intern/strings/smoke_script.h

Loading...