Details

Reviewers

Bastien Montagne (mont29)
Dalai Felinto (dfelinto)
Martijn Berger (juicyfruit)
Brecht Van Lommel (brecht)

Maniphest Tasks

T52807: Proposal: Remove macos quicktime exporter

Commits

rBSefd5e3c25401: Remove quicktime support
rBefd5e3c25401: Remove quicktime support

Summary

It has been deprecated since at least macOS 10.9 and fully removed in 10.12.

I am unsure if we should remove it only in 2.8. But you cannot build blender with it supported when using a modern xcode version anyway so I would tend towards just removing it also for 2.79 if that ever happens.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D2333

Build Status

Buildable 725
Build 725: arc lint + arc unit

Event Timeline

Martijn Berger (juicyfruit) updated this revision to Diff 7732.Nov 5 2016, 2:17 PM

Martijn Berger (juicyfruit) retitled this revision from to Remove quicktime. It has been deprecated since at least macOS 10.9 and fully removed in 10.12.

Martijn Berger (juicyfruit) updated this object.

Martijn Berger (juicyfruit) retitled this revision from Remove quicktime. It has been deprecated since at least macOS 10.9 and fully removed in 10.12 to Remove quicktime support.Nov 5 2016, 2:19 PM

Martijn Berger (juicyfruit) updated this object.

Martijn Berger (juicyfruit) added reviewers: Bastien Montagne (mont29), Dalai Felinto (dfelinto).

Didn’t check the code itself (trust you here ;) ), but we should definitively get rid of this oldy indeed!

@Brecht Van Lommel (brecht) may also have an opinion here, as a loyal OSX user? :P

This revision is now accepted and ready to land.Dec 28 2016, 2:22 PM

imb_ext_image_qt and imb_ext_movie_qt can be removed as well.

Personally I'm fine with removing this code from both branches.

CMakeLists.txt
338	The latest version of this CMakeLists.txt as has code to disable `WITH_CODEC_QUICKTIME` with the 10.12+ SDK that should be removed, but this patch seems to be against an older version.

Poke, is this too late to be merged in 2.79? Should be safe considering all the code is ifdefed

Aaron Carlisle (Blendify) commandeered this revision.Jul 18 2017, 4:48 AM

Aaron Carlisle (Blendify) added a reviewer: Martijn Berger (juicyfruit).

Remove Doxygen comment
Remove Py interface
Remove imb_ext_image_qt and imb_ext_movie_qt
Remove quicktime check
Remove Quicktime settings dna

Aaron Carlisle (Blendify) requested review of this revision.Jul 18 2017, 8:03 PM

Aaron Carlisle (Blendify) edited edge metadata.

Aaron Carlisle (Blendify) marked an inline comment as done.

There's still usage of qtcodecdata in BKE_scene.h, scene.c, readfile.c, writefile.c. Not sure how it can compile without updating those files.

Let's leave this for after the 2.79 release in any case.

source/blender/makesdna/DNA_scene_types.h
551–552	These should be removed.

This revision now requires changes to proceed.Jul 25 2017, 12:28 AM

Quicktime: Remove qtcodecdata

Aaron Carlisle (Blendify) marked an inline comment as done.Jul 25 2017, 4:39 AM

Remove some leftover rna/dna/py stuff

Brecht Van Lommel (brecht) requested changes to this revision.Jul 26 2017, 7:36 PM

Brecht Van Lommel (brecht) added inline comments.

release/scripts/startup/bl_ui/properties_render.py
468	This should not have been removed, it's for encoding into quicktime .mov format with ffmpeg.
source/blender/makesdna/DNA_scene_types.h
1693	Add `void *pad4;` below this line to fix DNA alignment on 32 bit.
source/blender/makesrna/intern/rna_scene.c
5408	This should not have been removed, it's for encoding into quicktime .mov format with ffmpeg.

This revision now requires changes to proceed.Jul 26 2017, 7:36 PM

Address Review

Looks good to me now.

This revision is now accepted and ready to land.Jul 26 2017, 11:59 PM

Aaron Carlisle (Blendify) mentioned this in T52805: 2.8: Proposals for feature removal / deprecation (parent task).Sep 18 2017, 4:23 AM

Aaron Carlisle (Blendify) added a task: T52807: Proposal: Remove macos quicktime exporter.Sep 18 2017, 4:51 AM

Closed by commit rBefd5e3c25401: Remove quicktime support (authored by Aaron Carlisle (Blendify)). · Explain WhySep 22 2017, 10:42 PM

This revision was automatically updated to reflect the committed changes.

Ray Molenkamp (LazyDodo) mentioned this in T63253: AVI is available but MOV not available.Apr 3 2019, 5:08 PM

I am still stubborn to ask you again, again again until you put back .mov and .mp4 for Macintosh please do it. I am very frustrate they support .avi for Windows. Please do it put back .mov and .mp4 thanks.

@Kent Davis (mac4kent) rendering to quicktime and mp4 formats is still possible this change removes Apples depreciated system for outputting these file formats. The same results are possible using blender's implementation of FFmpeg.

Remove quicktime supportClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9026

CMakeLists.txt

build_files/buildbot/slave_compile.py

build_files/cmake/config/blender_full.cmake

build_files/cmake/config/blender_lite.cmake

build_files/cmake/config/blender_release.cmake

build_files/cmake/macros.cmake

build_files/cmake/platform/platform_apple.cmake

build_files/cmake/platform/platform_apple_xcode.cmake

doc/doxygen/doxygen.source.h

intern/ghost/CMakeLists.txt

release/scripts/startup/bl_ui/properties_render.py

source/blender/CMakeLists.txt

source/blender/blenkernel/BKE_global.h

source/blender/blenkernel/BKE_scene.h

source/blender/blenkernel/CMakeLists.txt

source/blender/blenkernel/intern/image.c

source/blender/blenkernel/intern/scene.c

source/blender/blenkernel/intern/writeavi.c

source/blender/blenloader/intern/readfile.c

source/blender/blenloader/intern/writefile.c

source/blender/editors/render/CMakeLists.txt

source/blender/editors/space_file/filelist.c

source/blender/imbuf/CMakeLists.txt

source/blender/imbuf/IMB_imbuf_types.h

source/blender/imbuf/intern/IMB_anim.h

source/blender/imbuf/intern/anim_movie.c

source/blender/imbuf/intern/filetype.c

source/blender/imbuf/intern/util.c

source/blender/makesdna/DNA_scene_types.h

source/blender/makesrna/intern/CMakeLists.txt

source/blender/makesrna/intern/rna_scene.c

source/blender/python/intern/CMakeLists.txt

source/blender/python/intern/bpy_app_build_options.c

source/blender/quicktime/CMakeLists.txt

source/blender/quicktime/apple/qtkit_export.m

source/blender/quicktime/apple/qtkit_import.m

source/blender/quicktime/quicktime_export.h

source/blender/quicktime/quicktime_import.h

source/blender/render/CMakeLists.txt

source/blender/render/intern/source/initrender.c

source/blender/windowmanager/CMakeLists.txt

source/blenderplayer/CMakeLists.txt

source/creator/creator_args.c

Remove quicktime support
ClosedPublic
Actions

Revision Contents
Changeset List