First accepted part of D2254
ClosedPublic
Actions

Authored by mathieu menuet (bliblubli) on Nov 6 2016, 5:22 PM.

Details

Reviewers

Mai Lavelle (maiself)
Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)
Lukas Stockner (lukasstockner97)

Summary

Compile with transparent shadows only if needed and enabled in the current scene. Depending on the scene, it gives between 1% (scene without transparent material) and 8% (BMW benchmark) speedup.

Diff Detail

Repository: rB Blender

Event Timeline

mathieu menuet (bliblubli) updated this revision to Diff 7747.Nov 6 2016, 5:22 PM

mathieu menuet (bliblubli) retitled this revision from to First accepted part of D2254.

mathieu menuet (bliblubli) updated this object.

mathieu menuet (bliblubli) added reviewers: Brecht Van Lommel (brecht), Lukas Stockner (lukasstockner97), Mai Lavelle (maiself).

mathieu menuet (bliblubli) set the repository for this revision to rB Blender.

mathieu menuet (bliblubli) updated this object.

mathieu menuet (bliblubli) added a child revision: D2340: Split-kernel: reorganize nodes to get maximal performance on Group 0 (clay render) and better perfs on group 1 and 2..Nov 6 2016, 6:14 PM

mathieu menuet (bliblubli) mentioned this in D2341: split-kernel: add new node features to speedup heavy production files..Nov 6 2016, 6:39 PM

mathieu menuet (bliblubli) mentioned this in D2254: 20% to 140% Speedup for the OpenCL kernel.Nov 12 2016, 5:03 PM

LGTM. Nice to have this even for the performance checks on various platforms

Nice to add more detailed information to the commit message what are the measurable benefits for users tho.

This revision is now accepted and ready to land.Nov 14 2016, 9:48 AM

mathieu menuet (bliblubli) updated this object.Nov 14 2016, 7:20 PM

mathieu menuet (bliblubli) edited edge metadata.

added a check for the integrator setting "cycles.use_transparent_shadows" as user may disable transparent shadows even if some transparent shaders are present in the scene. Thanks to @Mai Lavelle (maiself) for her help on finding this solution.

mathieu menuet (bliblubli) updated this object.Nov 15 2016, 7:55 PM

I've been asked to land this one, (fine, easy work) however changes have been done since the patch has been accepted, @Sergey Sharybin (sergey) do you want to take one final look?