Add more information to the error message on missing image editor
AbandonedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Nov 11 2016, 7:23 PM.

Details

Reviewers

Bastien Montagne (mont29)
Julian Eisel (Severin)

Summary

Follow up on T49611 and idea by @Vuk Gardašević (lijenstina)

Diff Detail

Repository: rB Blender

Event Timeline

Aaron Carlisle (Blendify) updated this revision to Diff 7785.Nov 11 2016, 7:23 PM

Aaron Carlisle (Blendify) retitled this revision from to Add more information to the error message on missing image editor.

Aaron Carlisle (Blendify) updated this object.

Aaron Carlisle (Blendify) added reviewers: Julian Eisel (Severin), Bastien Montagne (mont29).

Aaron Carlisle (Blendify) set the repository for this revision to rB Blender.

Aaron Carlisle (Blendify) added projects: BF Blender, User Interface.

Aaron Carlisle (Blendify) added a subscriber: Vuk Gardašević (lijenstina).

Don’t think this is really needed, windows user shall know that a 'standard user program' cannot launch an 'admin' one, period. This has nothing to do with Blender really. And do not like our tip or error messages to go too lengthy and corner-case-handling…

This revision now requires changes to proceed.Nov 13 2016, 6:10 PM

@Bastien Montagne (mont29) that's a valid point about user should know about running privileges, but the message is misleading in the case when the specified path is correct.

To further complicate things, Popen can fail in certain cases even if UAC is disabled due to windows awesomeness.

If there is no interest in this patch then it can be closed.

Bastien Montagne (mont29) mentioned this in rBcabd2dcecaef: Tweak error message when external image editor launching fails..Dec 28 2016, 2:12 PM

Committed slightly different message as rBcabd2dcecaef, thanks.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_operators/

image.py

5 lines

Diff 7785

View Options

release/scripts/startup/bl_operators/image.py

Add more information to the error message on missing image editorAbandonedPublicActions