Page MenuHome
Differential D234

Add Tab Theme Colors
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Jan 20 2014, 7:58 PM.

Details

Reviewers
Jonathan Williamson (carter2422)
Maniphest Tasks
T38169: Background Color of Vertical Tabs changes with "region text"
Summary

This adds four new theme colors to allow better customization of tabs. Previously the tab colors were interpolated from other theme colors, and while this was nice, it made getting nice themes very difficult. In particular, dark themes were difficult to make readable.

In addition this gives better color support when using a transparent region background as you can manually match the color (tabs don't support transparency yet).

Diff Detail

Branch
T38169

Event Timeline

Jonathan Williamson (carter2422) updated this revision to Unknown Object (????).Jan 20 2014, 8:27 PM
  • Removing tab colors from uiGradientColors. Was not needed.
Jonathan Williamson (carter2422) updated this revision to Unknown Object (????).Jan 20 2014, 9:45 PM
  • Update Blender 24x theme for tab colors
  • Update Elsyiun theme for tab colors
  • Update Hexagon theme for tab colors
  • Update Back to Black theme with tab colors
Jonathan Williamson (carter2422) updated this revision to Unknown Object (????).Jan 20 2014, 9:54 PM
  • Increment subversion number
Jonathan Williamson (carter2422) updated this revision to Unknown Object (????).Jan 20 2014, 10:04 PM
  • Remove old tab color interpolation lines.
Campbell Barton (campbellbarton) requested changes to this revision.Jan 21 2014, 2:36 AM
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/interface/resources.c
242

Since these are not so common, would place last in the switch statement (at least after TH_BUTBACK***)

2376

This only sets view3d tab background, it should set for all space types.
See UI_THEMESPACE_START/END use in this file.

Jonathan Williamson (carter2422) updated this revision to Unknown Object (????).Jan 22 2014, 10:42 PM
  • Move TH_TAB* lines to end of Switch statement
  • Set tab theme colors to all spaces
Campbell Barton (campbellbarton) added a comment.Jan 23 2014, 1:58 AM

Committed this patch with edits... see rB80af3d685773d58dbe73dc697658ddf93e81b0b7

release/scripts/presets/interface_theme/back_to_black.xml
285

I coulnt get the XML theme colors looking right, didnt include these changes in the patch since it looks like the themes need updating in other areas too (getting warning ThemeNodeEditor.operator_node not found) Back to black was ok but Blender2.4x not

source/blender/editors/interface/resources.c
810

This only sets the 3d view, as I've said before, tabs are not view3d specific, code that setups defaults shouldnt be view3d specific.

This issue here is rgba_char_args_test_set is used to set colors in ui_theme_init_new_do, remove the use of the test version so colors are always set now, this is no longer needed.

2378

This is a bit odd, just setting the ts->tab_active, etc in the for loop is more direct.

source/blender/makesdna/DNA_userdef_types.h
157

try avoid random whitespace, I meant to remove but slipped throuth :/

source/blender/makesrna/intern/rna_userdef.c
1191

De-duplicated this block. silly to have to add these in 2 places.

Campbell Barton (campbellbarton) added a comment.Jan 23 2014, 2:12 AM

Committed theme colors for back-to-black, elysuin and hexagon
rBc700103eabd2c5e80d05b85e6a2926485294eb49

Remaining themes are Ubuntu-Ambiabnce and Blender-2.4x

Campbell Barton (campbellbarton) commandeered this revision.Jan 28 2014, 3:37 PM
Campbell Barton (campbellbarton) abandoned this revision.
Campbell Barton (campbellbarton) edited reviewers, added: Jonathan Williamson (carter2422); removed: Campbell Barton (campbellbarton).

committed, closing. also committed ubuntu and blender theme updates,

Campbell Barton (campbellbarton) mentioned this in rBS80af3d685773: Tab theme colors.Nov 20 2014, 9:12 AM

Revision Contents
Changeset List

PathSize
release/
scripts/
presets/
interface_theme/
73 lines
60 lines
72 lines
66 lines
source/
blender/
blenkernel/
2 lines
editors/
include/
4 lines
interface/
16 lines
46 lines
makesdna/
7 lines
makesrna/
intern/
45 lines

Diff 726

View Options

release/scripts/presets/interface_theme/back_to_black.xml

Loading...
View Options

release/scripts/presets/interface_theme/blender_24x.xml

Loading...
View Options

release/scripts/presets/interface_theme/elsyiun.xml

Loading...
View Options

release/scripts/presets/interface_theme/hexagon.xml

Loading...
View Options

source/blender/blenkernel/BKE_blender.h

Loading...
View Options

source/blender/editors/include/UI_resources.h

Loading...
View Options

source/blender/editors/interface/interface_panel.c

Loading...
View Options

source/blender/editors/interface/resources.c

Loading...
View Options

source/blender/makesdna/DNA_userdef_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_userdef.c

Loading...